From d13f4b5948f4191209e0bc6d350e3ea0b41c22b0 Mon Sep 17 00:00:00 2001 From: Andrii Chubatiuk Date: Thu, 3 Jun 2021 20:04:04 +0300 Subject: [PATCH] fixed recv_errors spoofing condition (#482) Hi @nbrownus Fixed a small bug that was introduced in df7c7ee#diff-5d05d02296a1953fd5fbcb3f4ab486bc5f7c34b14c3bdedb068008ec8ff5beb4 having problems due to it --- CHANGELOG.md | 4 ++++ outside.go | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a54630..6681ffc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Valid recv_error packets were incorrectly marked as "spoofing" and ignored. (#482) + ## [1.4.0] - 2021-05-11 ### Added diff --git a/outside.go b/outside.go index 88cf6af..aad085d 100644 --- a/outside.go +++ b/outside.go @@ -340,7 +340,7 @@ func (f *Interface) handleRecvError(addr *udpAddr, h *Header) { if !hostinfo.RecvErrorExceeded() { return } - if hostinfo.remote != nil && hostinfo.remote.Equals(addr) { + if hostinfo.remote != nil && !hostinfo.remote.Equals(addr) { f.l.Infoln("Someone spoofing recv_errors? ", addr, hostinfo.remote) return }