drop packets even if we aren't going to emit Debug logs about it (#239)

* drop packets even if we aren't going to emit Debug logs about it

* smallify change
This commit is contained in:
Patrick Bogen 2020-06-10 14:55:49 -07:00 committed by GitHub
parent ff13aba8fc
commit ecf0e5a9f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 8 deletions

View File

@ -109,10 +109,12 @@ func (f *Interface) sendMessageNow(t NebulaMessageType, st NebulaMessageSubType,
// check if packet is in outbound fw rules // check if packet is in outbound fw rules
dropReason := f.firewall.Drop(p, *fp, false, hostInfo, trustedCAs) dropReason := f.firewall.Drop(p, *fp, false, hostInfo, trustedCAs)
if dropReason != nil && l.Level >= logrus.DebugLevel { if dropReason != nil {
l.WithField("fwPacket", fp). if l.Level >= logrus.DebugLevel {
WithField("reason", dropReason). l.WithField("fwPacket", fp).
Debugln("dropping cached packet") WithField("reason", dropReason).
Debugln("dropping cached packet")
}
return return
} }

View File

@ -281,10 +281,12 @@ func (f *Interface) decryptToTun(hostinfo *HostInfo, messageCounter uint64, out
} }
dropReason := f.firewall.Drop(out, *fwPacket, true, hostinfo, trustedCAs) dropReason := f.firewall.Drop(out, *fwPacket, true, hostinfo, trustedCAs)
if dropReason != nil && l.Level >= logrus.DebugLevel { if dropReason != nil {
hostinfo.logger().WithField("fwPacket", fwPacket). if l.Level >= logrus.DebugLevel {
WithField("reason", dropReason). hostinfo.logger().WithField("fwPacket", fwPacket).
Debugln("dropping inbound packet") WithField("reason", dropReason).
Debugln("dropping inbound packet")
}
return return
} }