terraform/builtin/providers/aws/resource_aws_cloudwatch_log...

175 lines
4.4 KiB
Go
Raw Normal View History

package aws
import (
"fmt"
"testing"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/lambda"
"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform"
)
func TestAccAWSCloudwatchLogSubscriptionFilter_basic(t *testing.T) {
var conf lambda.GetFunctionOutput
rstring := acctest.RandString(5)
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckCloudwatchLogSubscriptionFilterDestroy,
Steps: []resource.TestStep{
{
Config: testAccAWSCloudwatchLogSubscriptionFilterConfig(rstring),
Check: resource.ComposeTestCheckFunc(
testAccCheckAwsCloudwatchLogSubscriptionFilterExists("aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter", &conf, rstring),
testAccCheckAWSCloudwatchLogSubscriptionFilterAttributes(&conf, rstring),
),
},
},
})
}
func testAccCheckCloudwatchLogSubscriptionFilterDestroy(s *terraform.State) error {
conn := testAccProvider.Meta().(*AWSClient).lambdaconn
for _, rs := range s.RootModule().Resources {
if rs.Type != "aws_cloudwatch_log_subscription_filter" {
continue
}
_, err := conn.GetFunction(&lambda.GetFunctionInput{
FunctionName: aws.String(rs.Primary.ID),
})
if err == nil {
return fmt.Errorf("Lambda Function still exists")
}
}
return nil
}
func testAccCheckAwsCloudwatchLogSubscriptionFilterExists(n string, function *lambda.GetFunctionOutput, rstring string) resource.TestCheckFunc {
// Wait for IAM role
return func(s *terraform.State) error {
rs, ok := s.RootModule().Resources[n]
if !ok {
return fmt.Errorf("Lambda function not found: %s", n)
}
if rs.Primary.ID == "" {
return fmt.Errorf("Lambda function ID not set")
}
conn := testAccProvider.Meta().(*AWSClient).lambdaconn
params := &lambda.GetFunctionInput{
FunctionName: aws.String("example_lambda_name_" + rstring),
}
getFunction, err := conn.GetFunction(params)
if err != nil {
return err
}
*function = *getFunction
return nil
}
}
func testAccCheckAWSCloudwatchLogSubscriptionFilterAttributes(function *lambda.GetFunctionOutput, rstring string) resource.TestCheckFunc {
return func(s *terraform.State) error {
c := function.Configuration
expectedName := fmt.Sprintf("example_lambda_name_%s", rstring)
if *c.FunctionName != expectedName {
return fmt.Errorf("Expected function name %s, got %s", expectedName, *c.FunctionName)
}
if *c.FunctionArn == "" {
return fmt.Errorf("Could not read Lambda Function's ARN")
}
return nil
}
}
func testAccAWSCloudwatchLogSubscriptionFilterConfig(rstring string) string {
return fmt.Sprintf(`
resource "aws_cloudwatch_log_subscription_filter" "test_lambdafunction_logfilter" {
provider/aws: Refresh cloudwatch log subscription filter on 404 (#12333) Fixes:#11750 Before this change, adding a log_subscription_filter and then deleting it manually would yield this error on terraform plan/apply: ``` % terraform plan ✹ ✭ Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) Error refreshing state: 1 error(s) occurred: * aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Subscription filter for log group example_lambda_name with name prefix test_lambdafunction_logfilter not found! ``` After this patch, we get the following behaviour: ``` % terraform plan ✹ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter destination_arn: "arn:aws:lambda:us-west-2:187416307283:function:example_lambda_name_example123" filter_pattern: "logtype test" log_group_name: "example_lambda_name" name: "test_lambdafunction_logfilter" role_arn: "<computed>" Plan: 1 to add, 0 to change, 0 to destroy. ```
2017-03-01 23:12:50 +01:00
name = "test_lambdafunction_logfilter_%s"
log_group_name = "example_lambda_name"
filter_pattern = "logtype test"
destination_arn = "${aws_lambda_function.test_lambdafunction.arn}"
}
resource "aws_lambda_function" "test_lambdafunction" {
filename = "test-fixtures/lambdatest.zip"
function_name = "example_lambda_name_%s"
role = "${aws_iam_role.iam_for_lambda.arn}"
runtime = "nodejs4.3"
handler = "exports.handler"
}
resource "aws_cloudwatch_log_group" "logs" {
provider/aws: Refresh cloudwatch log subscription filter on 404 (#12333) Fixes:#11750 Before this change, adding a log_subscription_filter and then deleting it manually would yield this error on terraform plan/apply: ``` % terraform plan ✹ ✭ Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) Error refreshing state: 1 error(s) occurred: * aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Subscription filter for log group example_lambda_name with name prefix test_lambdafunction_logfilter not found! ``` After this patch, we get the following behaviour: ``` % terraform plan ✹ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter destination_arn: "arn:aws:lambda:us-west-2:187416307283:function:example_lambda_name_example123" filter_pattern: "logtype test" log_group_name: "example_lambda_name" name: "test_lambdafunction_logfilter" role_arn: "<computed>" Plan: 1 to add, 0 to change, 0 to destroy. ```
2017-03-01 23:12:50 +01:00
name = "example_lambda_name_%s"
retention_in_days = 1
}
resource "aws_lambda_permission" "allow_cloudwatch_logs" {
statement_id = "AllowExecutionFromCloudWatchLogs"
action = "lambda:*"
function_name = "${aws_lambda_function.test_lambdafunction.arn}"
principal = "logs.us-west-2.amazonaws.com"
}
resource "aws_iam_role" "iam_for_lambda" {
name = "test_lambdafuntion_iam_role_%s"
assume_role_policy = <<EOF
{
"Version": "2012-10-17",
"Statement": [
{
"Action": "sts:AssumeRole",
"Principal": {
"Service": "lambda.amazonaws.com"
},
"Effect": "Allow",
"Sid": ""
}
]
}
EOF
}
resource "aws_iam_role_policy" "test_lambdafunction_iam_policy" {
provider/aws: Refresh cloudwatch log subscription filter on 404 (#12333) Fixes:#11750 Before this change, adding a log_subscription_filter and then deleting it manually would yield this error on terraform plan/apply: ``` % terraform plan ✹ ✭ Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) Error refreshing state: 1 error(s) occurred: * aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Subscription filter for log group example_lambda_name with name prefix test_lambdafunction_logfilter not found! ``` After this patch, we get the following behaviour: ``` % terraform plan ✹ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter destination_arn: "arn:aws:lambda:us-west-2:187416307283:function:example_lambda_name_example123" filter_pattern: "logtype test" log_group_name: "example_lambda_name" name: "test_lambdafunction_logfilter" role_arn: "<computed>" Plan: 1 to add, 0 to change, 0 to destroy. ```
2017-03-01 23:12:50 +01:00
name = "test_lambdafunction_iam_policy_%s"
role = "${aws_iam_role.iam_for_lambda.id}"
policy = <<EOF
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "Stmt1441111030000",
"Effect": "Allow",
"Action": [
provider/aws: Refresh cloudwatch log subscription filter on 404 (#12333) Fixes:#11750 Before this change, adding a log_subscription_filter and then deleting it manually would yield this error on terraform plan/apply: ``` % terraform plan ✹ ✭ Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) Error refreshing state: 1 error(s) occurred: * aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Subscription filter for log group example_lambda_name with name prefix test_lambdafunction_logfilter not found! ``` After this patch, we get the following behaviour: ``` % terraform plan ✹ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter destination_arn: "arn:aws:lambda:us-west-2:187416307283:function:example_lambda_name_example123" filter_pattern: "logtype test" log_group_name: "example_lambda_name" name: "test_lambdafunction_logfilter" role_arn: "<computed>" Plan: 1 to add, 0 to change, 0 to destroy. ```
2017-03-01 23:12:50 +01:00
"lambda:*"
],
"Resource": [
"*"
]
}
]
}
EOF
}
provider/aws: Refresh cloudwatch log subscription filter on 404 (#12333) Fixes:#11750 Before this change, adding a log_subscription_filter and then deleting it manually would yield this error on terraform plan/apply: ``` % terraform plan ✹ ✭ Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) Error refreshing state: 1 error(s) occurred: * aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Subscription filter for log group example_lambda_name with name prefix test_lambdafunction_logfilter not found! ``` After this patch, we get the following behaviour: ``` % terraform plan ✹ ✭ [WARN] /Users/stacko/Code/go/bin/terraform-provider-aws overrides an internal plugin for aws-provider. If you did not expect to see this message you will need to remove the old plugin. See https://www.terraform.io/docs/internals/internal-plugins.html Refreshing Terraform state in-memory prior to plan... The refreshed state will be used to calculate this plan, but will not be persisted to local or remote state storage. aws_iam_role.iam_for_lambda: Refreshing state... (ID: test_lambdafuntion_iam_role_example123) aws_cloudwatch_log_group.logs: Refreshing state... (ID: example_lambda_name) aws_lambda_function.test_lambdafunction: Refreshing state... (ID: example_lambda_name_example123) aws_iam_role_policy.test_lambdafunction_iam_policy: Refreshing state... (ID: test_lambdafuntion_iam_role_example123:test_lambdafunction_iam_policy) aws_lambda_permission.allow_cloudwatch_logs: Refreshing state... (ID: AllowExecutionFromCloudWatchLogs) aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter: Refreshing state... (ID: cwlsf-992677504) The Terraform execution plan has been generated and is shown below. Resources are shown in alphabetical order for quick scanning. Green resources will be created (or destroyed and then created if an existing resource exists), yellow resources are being changed in-place, and red resources will be destroyed. Cyan entries are data sources to be read. Note: You didn't specify an "-out" parameter to save this plan, so when "apply" is called, Terraform can't guarantee this is what will execute. + aws_cloudwatch_log_subscription_filter.test_lambdafunction_logfilter destination_arn: "arn:aws:lambda:us-west-2:187416307283:function:example_lambda_name_example123" filter_pattern: "logtype test" log_group_name: "example_lambda_name" name: "test_lambdafunction_logfilter" role_arn: "<computed>" Plan: 1 to add, 0 to change, 0 to destroy. ```
2017-03-01 23:12:50 +01:00
`, rstring, rstring, rstring, rstring, rstring)
}