2016-06-22 02:16:02 +02:00
|
|
|
package aws
|
|
|
|
|
|
|
|
import (
|
|
|
|
"encoding/base64"
|
|
|
|
"fmt"
|
2016-09-22 22:22:27 +02:00
|
|
|
"log"
|
2016-06-22 02:16:02 +02:00
|
|
|
"testing"
|
2016-09-22 22:22:27 +02:00
|
|
|
"time"
|
2016-06-22 02:16:02 +02:00
|
|
|
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
|
|
"github.com/aws/aws-sdk-go/service/ec2"
|
2016-08-25 15:40:57 +02:00
|
|
|
"github.com/hashicorp/terraform/helper/acctest"
|
2016-06-22 02:16:02 +02:00
|
|
|
"github.com/hashicorp/terraform/helper/resource"
|
|
|
|
"github.com/hashicorp/terraform/terraform"
|
|
|
|
)
|
|
|
|
|
2016-08-24 12:08:46 +02:00
|
|
|
func TestAccAWSSpotFleetRequest_changePriceForcesNewRequest(t *testing.T) {
|
|
|
|
var before, after ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfig(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &before),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_price", "0.005"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "1"),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigChangeSpotBidPrice(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &after),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "1"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_price", "0.01"),
|
|
|
|
testAccCheckAWSSpotFleetRequestConfigRecreated(t, &before, &after),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion(t *testing.T) {
|
2016-06-22 02:16:02 +02:00
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-06-22 02:16:02 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfig(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "1"),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList(t *testing.T) {
|
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigWithAzs(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "2"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.1590006269.availability_zone", "us-west-2a"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.3809475891.availability_zone", "us-west-2b"),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList(t *testing.T) {
|
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigWithSubnet(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "2"),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz(t *testing.T) {
|
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigMultipleInstanceTypesinSameAz(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "2"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.1590006269.instance_type", "m1.small"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.1590006269.availability_zone", "us-west-2a"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.3079734941.instance_type", "m3.large"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.3079734941.availability_zone", "us-west-2a"),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet(t *testing.T) {
|
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigMultipleInstanceTypesinSameSubnet(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "2"),
|
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_overriddingSpotPrice(t *testing.T) {
|
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigOverridingSpotPrice(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
2016-06-22 02:16:02 +02:00
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
2016-08-24 12:08:46 +02:00
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_price", "0.005"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "2"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.522395050.spot_price", "0.01"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.522395050.instance_type", "m3.large"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.1590006269.spot_price", ""), //there will not be a value here since it's not overriding
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.1590006269.instance_type", "m1.small"),
|
2016-06-22 02:16:02 +02:00
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2016-08-24 12:08:46 +02:00
|
|
|
func TestAccAWSSpotFleetRequest_diversifiedAllocation(t *testing.T) {
|
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-08-24 12:08:46 +02:00
|
|
|
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigDiversifiedAllocation(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "3"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "allocation_strategy", "diversified"),
|
|
|
|
),
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2016-08-24 12:08:46 +02:00
|
|
|
func TestAccAWSSpotFleetRequest_withWeightedCapacity(t *testing.T) {
|
2016-06-22 02:16:02 +02:00
|
|
|
var sfr ec2.SpotFleetRequestConfig
|
2016-08-25 15:40:57 +02:00
|
|
|
rName := acctest.RandString(10)
|
2016-06-22 02:16:02 +02:00
|
|
|
|
2016-09-22 22:22:27 +02:00
|
|
|
fulfillSleep := func() resource.TestCheckFunc {
|
|
|
|
// sleep so that EC2 can fuflill the request. We do this to guard against a
|
|
|
|
// regression and possible leak where we'll destroy the request and the
|
|
|
|
// associated IAM role before anything is actually provisioned and running,
|
|
|
|
// thus leaking when those newly started instances are attempted to be
|
|
|
|
// destroyed
|
|
|
|
// See https://github.com/hashicorp/terraform/pull/8938
|
|
|
|
return func(s *terraform.State) error {
|
|
|
|
log.Printf("[DEBUG] Test: Sleep to allow EC2 to actually begin fulfilling TestAccAWSSpotFleetRequest_withWeightedCapacity request")
|
|
|
|
time.Sleep(1 * time.Minute)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-22 02:16:02 +02:00
|
|
|
resource.Test(t, resource.TestCase{
|
|
|
|
PreCheck: func() { testAccPreCheck(t) },
|
|
|
|
Providers: testAccProviders,
|
|
|
|
CheckDestroy: testAccCheckAWSSpotFleetRequestDestroy,
|
|
|
|
Steps: []resource.TestStep{
|
|
|
|
resource.TestStep{
|
2016-08-25 15:40:57 +02:00
|
|
|
Config: testAccAWSSpotFleetRequestConfigWithWeightedCapacity(rName),
|
2016-08-24 12:08:46 +02:00
|
|
|
Check: resource.ComposeAggregateTestCheckFunc(
|
2016-09-22 22:22:27 +02:00
|
|
|
fulfillSleep(),
|
2016-06-22 02:16:02 +02:00
|
|
|
testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
"aws_spot_fleet_request.foo", &sfr),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "spot_request_state", "active"),
|
2016-08-24 12:08:46 +02:00
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.#", "2"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.2325690000.weighted_capacity", "3"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.2325690000.instance_type", "r3.large"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.3079734941.weighted_capacity", "6"),
|
|
|
|
resource.TestCheckResourceAttr(
|
|
|
|
"aws_spot_fleet_request.foo", "launch_specification.3079734941.instance_type", "m3.large"),
|
2016-06-22 02:16:02 +02:00
|
|
|
),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName(t *testing.T) {
|
|
|
|
_, errors := validateSpotFleetRequestKeyName("", "key_name")
|
|
|
|
if len(errors) == 0 {
|
|
|
|
t.Fatalf("Expected the key name to trigger a validation error")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-08-24 12:08:46 +02:00
|
|
|
func testAccCheckAWSSpotFleetRequestConfigRecreated(t *testing.T,
|
|
|
|
before, after *ec2.SpotFleetRequestConfig) resource.TestCheckFunc {
|
|
|
|
return func(s *terraform.State) error {
|
|
|
|
if before.SpotFleetRequestId == after.SpotFleetRequestId {
|
|
|
|
t.Fatalf("Expected change of Spot Fleet Request IDs, but both were %v", before.SpotFleetRequestId)
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-22 02:16:02 +02:00
|
|
|
func testAccCheckAWSSpotFleetRequestExists(
|
|
|
|
n string, sfr *ec2.SpotFleetRequestConfig) resource.TestCheckFunc {
|
|
|
|
return func(s *terraform.State) error {
|
|
|
|
rs, ok := s.RootModule().Resources[n]
|
|
|
|
if !ok {
|
|
|
|
return fmt.Errorf("Not found: %s", n)
|
|
|
|
}
|
|
|
|
|
|
|
|
if rs.Primary.ID == "" {
|
|
|
|
return fmt.Errorf("No Spot fleet request with that id exists")
|
|
|
|
}
|
|
|
|
|
|
|
|
conn := testAccProvider.Meta().(*AWSClient).ec2conn
|
|
|
|
|
|
|
|
params := &ec2.DescribeSpotFleetRequestsInput{
|
|
|
|
SpotFleetRequestIds: []*string{&rs.Primary.ID},
|
|
|
|
}
|
|
|
|
resp, err := conn.DescribeSpotFleetRequests(params)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if v := len(resp.SpotFleetRequestConfigs); v != 1 {
|
|
|
|
return fmt.Errorf("Expected 1 request returned, got %d", v)
|
|
|
|
}
|
|
|
|
|
|
|
|
*sfr = *resp.SpotFleetRequestConfigs[0]
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func testAccCheckAWSSpotFleetRequest_LaunchSpecAttributes(
|
|
|
|
sfr *ec2.SpotFleetRequestConfig) resource.TestCheckFunc {
|
|
|
|
return func(s *terraform.State) error {
|
|
|
|
if len(sfr.SpotFleetRequestConfig.LaunchSpecifications) == 0 {
|
|
|
|
return fmt.Errorf("Missing launch specification")
|
|
|
|
}
|
|
|
|
|
|
|
|
spec := *sfr.SpotFleetRequestConfig.LaunchSpecifications[0]
|
|
|
|
|
2016-06-23 09:13:49 +02:00
|
|
|
if *spec.InstanceType != "m1.small" {
|
2016-06-22 02:16:02 +02:00
|
|
|
return fmt.Errorf("Unexpected launch specification instance type: %s", *spec.InstanceType)
|
|
|
|
}
|
|
|
|
|
2016-06-23 09:13:49 +02:00
|
|
|
if *spec.ImageId != "ami-d06a90b0" {
|
2016-06-22 02:16:02 +02:00
|
|
|
return fmt.Errorf("Unexpected launch specification image id: %s", *spec.ImageId)
|
|
|
|
}
|
|
|
|
|
|
|
|
if *spec.SpotPrice != "0.01" {
|
|
|
|
return fmt.Errorf("Unexpected launch specification spot price: %s", *spec.SpotPrice)
|
|
|
|
}
|
|
|
|
|
|
|
|
if *spec.WeightedCapacity != 2 {
|
|
|
|
return fmt.Errorf("Unexpected launch specification weighted capacity: %f", *spec.WeightedCapacity)
|
|
|
|
}
|
|
|
|
|
|
|
|
if *spec.UserData != base64.StdEncoding.EncodeToString([]byte("hello-world")) {
|
|
|
|
return fmt.Errorf("Unexpected launch specification user data: %s", *spec.UserData)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func testAccCheckAWSSpotFleetRequestDestroy(s *terraform.State) error {
|
|
|
|
conn := testAccProvider.Meta().(*AWSClient).ec2conn
|
|
|
|
|
|
|
|
for _, rs := range s.RootModule().Resources {
|
|
|
|
if rs.Type != "aws_spot_fleet_request" {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
_, err := conn.CancelSpotFleetRequests(&ec2.CancelSpotFleetRequestsInput{
|
|
|
|
SpotFleetRequestIds: []*string{aws.String(rs.Primary.ID)},
|
|
|
|
TerminateInstances: aws.Bool(true),
|
|
|
|
})
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("Error cancelling spot request (%s): %s", rs.Primary.ID, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfig(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-06-22 02:16:02 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-06-22 02:16:02 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-06-22 02:16:02 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-06-22 02:16:02 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.005"
|
|
|
|
target_capacity = 2
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
2016-08-24 12:08:46 +02:00
|
|
|
terminate_instances_with_expiration = true
|
2016-06-22 02:16:02 +02:00
|
|
|
launch_specification {
|
2016-06-23 09:13:49 +02:00
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
2016-06-22 02:16:02 +02:00
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-06-22 02:16:02 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigChangeSpotBidPrice(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-08-24 12:08:46 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.01"
|
|
|
|
target_capacity = 2
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-08-24 12:08:46 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigWithAzs(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.005"
|
|
|
|
target_capacity = 2
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
2016-08-24 12:08:46 +02:00
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
launch_specification {
|
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
2016-08-24 12:08:46 +02:00
|
|
|
availability_zone = "us-west-2b"
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
provider/aws: `aws_spot_fleet_request` throws panic on missing subnet_id (#8217)
or availability_zone
Fixes #8000
There was a hard coded panic in the code!!!
```
panic(
fmt.Sprintf(
"Must set one of:\navailability_zone %#v\nsubnet_id: %#v",
m["availability_zone"],
m["subnet_id"])
)
```
This was causing issues when we set neither an availability zone or a subnet id.
This has been removed and is now handled with an error rather than a panic.
This was what happened with the new test before the fix:
```
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
panic: Must set one of:
availability_zone ""
subnet_id: ""
goroutine 129 [running]:
panic(0x11377a0, 0xc8202abfc0)
/opt/boxen/homebrew/Cellar/go/1.6.2/libexec/src/runtime/panic.go:481 +0x3e6
github.com/hashicorp/terraform/builtin/providers/aws.hashLaunchSpecification(0x11361a0, 0xc8202e07e0, 0xc800000001)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/builtin/providers/aws/resource_aws_spot_fleet_request.go:953 +0x685
github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0x0, 0x0)
/Users/stacko/Code/go/src/github.com/hashicorp/terraform/helper/schema/set.go:180 +0x40
github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc82005ae00, 0x11361a0, 0xc8202e07e0, 0xc820276900, 0x0, 0x0)
```
The test then ran fine after the fix:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:03:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_brokenLaunchSpecification -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (32.37s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 32.384s
```
Full test run looks as follows:
```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSpotFleetRequest_' ✹
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/16 08:04:34 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSpotFleetRequest_ -timeout 120m
=== RUN TestAccAWSSpotFleetRequest_basic
--- PASS: TestAccAWSSpotFleetRequest_basic (33.78s)
=== RUN TestAccAWSSpotFleetRequest_brokenLaunchSpecification
--- PASS: TestAccAWSSpotFleetRequest_brokenLaunchSpecification (33.59s)
=== RUN TestAccAWSSpotFleetRequest_launchConfiguration
--- PASS: TestAccAWSSpotFleetRequest_launchConfiguration (35.26s)
=== RUN TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName
--- PASS: TestAccAWSSpotFleetRequest_CannotUseEmptyKeyName (0.00s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/aws 102.648s
```
2016-08-16 18:55:06 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigWithSubnet(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-06-22 02:16:02 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-06-22 02:16:02 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-06-22 02:16:02 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-06-22 02:16:02 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_vpc" "foo" {
|
|
|
|
cidr_block = "10.1.0.0/16"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_subnet" "foo" {
|
|
|
|
cidr_block = "10.1.1.0/24"
|
|
|
|
vpc_id = "${aws_vpc.foo.id}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_subnet" "bar" {
|
|
|
|
cidr_block = "10.1.20.0/24"
|
|
|
|
vpc_id = "${aws_vpc.foo.id}"
|
|
|
|
availability_zone = "us-west-2b"
|
|
|
|
}
|
|
|
|
|
2016-06-22 02:16:02 +02:00
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.005"
|
|
|
|
target_capacity = 4
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
2016-08-24 12:08:46 +02:00
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d0f506b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
subnet_id = "${aws_subnet.foo.id}"
|
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d0f506b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
subnet_id = "${aws_subnet.bar.id}"
|
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-08-24 12:08:46 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigMultipleInstanceTypesinSameAz(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-08-24 12:08:46 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.005"
|
|
|
|
target_capacity = 2
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-08-24 12:08:46 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigMultipleInstanceTypesinSameSubnet(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-08-24 12:08:46 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_vpc" "foo" {
|
|
|
|
cidr_block = "10.1.0.0/16"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_subnet" "foo" {
|
|
|
|
cidr_block = "10.1.1.0/24"
|
|
|
|
vpc_id = "${aws_vpc.foo.id}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.005"
|
|
|
|
target_capacity = 4
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d0f506b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
subnet_id = "${aws_subnet.foo.id}"
|
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "r3.large"
|
|
|
|
ami = "ami-d0f506b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
subnet_id = "${aws_subnet.foo.id}"
|
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-08-24 12:08:46 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigOverridingSpotPrice(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-08-24 12:08:46 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.005"
|
|
|
|
target_capacity = 2
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
|
|
|
terminate_instances_with_expiration = true
|
2016-06-22 02:16:02 +02:00
|
|
|
launch_specification {
|
2016-06-23 09:13:49 +02:00
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
2016-06-22 02:16:02 +02:00
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
2016-06-23 09:13:49 +02:00
|
|
|
availability_zone = "us-west-2a"
|
2016-08-24 12:08:46 +02:00
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
2016-06-22 02:16:02 +02:00
|
|
|
spot_price = "0.01"
|
2016-08-24 12:08:46 +02:00
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-08-24 12:08:46 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigDiversifiedAllocation(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-08-24 12:08:46 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.7"
|
|
|
|
target_capacity = 30
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
|
|
|
allocation_strategy = "diversified"
|
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m1.small"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "r3.large"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|
2016-08-24 12:08:46 +02:00
|
|
|
|
2016-08-25 15:40:57 +02:00
|
|
|
func testAccAWSSpotFleetRequestConfigWithWeightedCapacity(rName string) string {
|
|
|
|
return fmt.Sprintf(`
|
2016-08-24 12:08:46 +02:00
|
|
|
resource "aws_key_pair" "debugging" {
|
2016-08-25 15:40:57 +02:00
|
|
|
key_name = "tmp-key-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQD3F6tyPEFEzV0LX3X8BsXdMsQz1x2cEikKDEY0aIj41qgxMCP/iteneqXSIFZBp5vizPvaoIR3Um9xK7PGoW8giupGn+EPuxIA4cDM4vzOqOkiMPhz5XK0whEjkVzTo4+S0puvDZuwIsdiW9mxhJc7tgBNL0cYlWSYVkz4G/fslNfRPW5mYAM49f4fhtxPb5ok4Q2Lg9dPKVHO/Bgeu5woMc7RY0p1ej6D4CKFE6lymSDJpW0YHX/wqE9+cfEauh7xZcG0q9t2ta6F6fmX0agvpFyZo8aFbXeUBr7osSCJNgvavWbM/06niWrOvYX2xwWdhXmXSrbX8ZbabVohBK41 phodgson@thoughtworks.com"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_policy_attachment" "test-attach" {
|
|
|
|
name = "test-attachment"
|
|
|
|
roles = ["${aws_iam_role.test-role.name}"]
|
|
|
|
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2SpotFleetRole"
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_iam_role" "test-role" {
|
2016-08-25 15:40:57 +02:00
|
|
|
name = "test-role-%s"
|
2016-08-24 12:08:46 +02:00
|
|
|
assume_role_policy = <<EOF
|
|
|
|
{
|
|
|
|
"Version": "2012-10-17",
|
|
|
|
"Statement": [
|
|
|
|
{
|
|
|
|
"Sid": "",
|
|
|
|
"Effect": "Allow",
|
|
|
|
"Principal": {
|
2016-08-31 12:25:08 +02:00
|
|
|
"Service": [
|
|
|
|
"spotfleet.amazonaws.com",
|
|
|
|
"ec2.amazonaws.com"
|
|
|
|
]
|
2016-08-24 12:08:46 +02:00
|
|
|
},
|
|
|
|
"Action": "sts:AssumeRole"
|
|
|
|
}
|
|
|
|
]
|
|
|
|
}
|
|
|
|
EOF
|
|
|
|
}
|
|
|
|
|
|
|
|
resource "aws_spot_fleet_request" "foo" {
|
|
|
|
iam_fleet_role = "${aws_iam_role.test-role.arn}"
|
|
|
|
spot_price = "0.7"
|
|
|
|
target_capacity = 10
|
|
|
|
valid_until = "2019-11-04T20:44:20Z"
|
|
|
|
terminate_instances_with_expiration = true
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "m3.large"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
weighted_capacity = "6"
|
|
|
|
}
|
|
|
|
launch_specification {
|
|
|
|
instance_type = "r3.large"
|
|
|
|
ami = "ami-d06a90b0"
|
|
|
|
key_name = "${aws_key_pair.debugging.key_name}"
|
|
|
|
availability_zone = "us-west-2a"
|
|
|
|
weighted_capacity = "3"
|
2016-06-22 02:16:02 +02:00
|
|
|
}
|
|
|
|
depends_on = ["aws_iam_policy_attachment.test-attach"]
|
|
|
|
}
|
2016-08-25 15:40:57 +02:00
|
|
|
`, rName, rName)
|
|
|
|
}
|