From eb6fd87a4232d79bbfc782c8d7eae83029d72965 Mon Sep 17 00:00:00 2001 From: stack72 Date: Thu, 21 Jan 2016 20:59:30 +0000 Subject: [PATCH] Fixing a flapping AzureRM PublicIP validation test --- .../azurerm/resource_arm_public_ip_test.go | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/builtin/providers/azurerm/resource_arm_public_ip_test.go b/builtin/providers/azurerm/resource_arm_public_ip_test.go index 36ee500a9..e9857acf0 100644 --- a/builtin/providers/azurerm/resource_arm_public_ip_test.go +++ b/builtin/providers/azurerm/resource_arm_public_ip_test.go @@ -2,11 +2,10 @@ package azurerm import ( "fmt" - "math/rand" "net/http" "testing" - "time" + "github.com/hashicorp/terraform/helper/acctest" "github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/terraform" ) @@ -65,7 +64,7 @@ func TestResourceAzureRMPublicIpDomainNameLabel_validation(t *testing.T) { ErrCount: 1, }, { - Value: randomString(80), + Value: acctest.RandString(80), ErrCount: 1, }, } @@ -227,16 +226,6 @@ func testCheckAzureRMPublicIpDestroy(s *terraform.State) error { return nil } -func randomString(strlen int) string { - rand.Seed(time.Now().UTC().UnixNano()) - const chars = "abcdefghijklmnopqrstuvwxyz0123456789-" - result := make([]byte, strlen) - for i := 0; i < strlen; i++ { - result[i] = chars[rand.Intn(len(chars))] - } - return string(result) -} - var testAccAzureRMVPublicIpStatic_basic = ` resource "azurerm_resource_group" "test" { name = "acceptanceTestResourceGroup1"