terraform: module dependencies in graph use full name (FOR THE FUTURE)

terraform/graph_config_node.go

@@ -58,7 +58,15 @@ func (n *GraphNodeConfigModule) ConfigType() GraphNodeConfigType {
 }
 
 func (n *GraphNodeConfigModule) DependableName() []string {
-	return []string{n.Name()}
+	config := n.Tree.Config()
+
+	result := make([]string, 1, len(config.Outputs)+1)
+	result[0] = n.Name()
+	for _, o := range config.Outputs {
+		result = append(result, fmt.Sprintf("%s.%s", n.Name(), o.Name))
+	}
+
+	return result
 }
 
 func (n *GraphNodeConfigModule) DependentOn() []string {

terraform/test-fixtures/graph-modules/consul/main.tf

@@ -1 +1,3 @@
 resource "aws_instance" "server" {}
+
+output "security_group" { value = "" }

terraform/transform_config.go

@@ -105,7 +105,7 @@ func (t *ConfigTransformer) Transform(g *Graph) error {
 func varNameForVar(raw config.InterpolatedVariable) string {
 	switch v := raw.(type) {
 	case *config.ModuleVariable:
-		return fmt.Sprintf("module.%s", v.Name)
+		return fmt.Sprintf("module.%s.%s", v.Name, v.Field)
 	case *config.ResourceVariable:
 		return v.ResourceId()
 	case *config.UserVariable:

terraform/transform_resource.go

@@ -174,9 +174,18 @@ func (n *graphNodeExpandedResource) StateDependencies() []string {
 	depsRaw := n.DependentOn()
 	deps := make([]string, 0, len(depsRaw))
 	for _, d := range depsRaw {
-		if !strings.HasPrefix(d, "var.") {
-			deps = append(deps, d)
+		// Ignore any variable dependencies
+		if strings.HasPrefix(d, "var.") {
+			continue
 		}
+
+		// This is sad. The dependencies are currently in the format of
+		// "module.foo.bar" (the full field). This strips the field off.
+		if strings.HasPrefix(d, "module.") {
+			parts := strings.SplitN(d, ".", 3)
+			d = strings.Join(parts[0:2], ".")
+		}
+		deps = append(deps, d)
 	}
 
 	return deps