From 16b368e292af2e8329582aa1b31930b67271cec2 Mon Sep 17 00:00:00 2001 From: James Bardin Date: Mon, 21 Oct 2019 14:42:40 -0400 Subject: [PATCH] only need to handle depends_on to shim old state --- helper/resource/state_shim.go | 2 +- helper/resource/state_shim_test.go | 36 +++++++++++++++--------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/helper/resource/state_shim.go b/helper/resource/state_shim.go index 5ddd02020..afd60b318 100644 --- a/helper/resource/state_shim.go +++ b/helper/resource/state_shim.go @@ -87,7 +87,7 @@ func shimNewState(newState *states.State, providers map[string]terraform.Resourc resState.Primary.Meta["schema_version"] = i.Current.SchemaVersion } - for _, dep := range i.Current.Dependencies { + for _, dep := range i.Current.DependsOn { resState.Dependencies = append(resState.Dependencies, dep.String()) } diff --git a/helper/resource/state_shim_test.go b/helper/resource/state_shim_test.go index e87a87e9e..a9c101a45 100644 --- a/helper/resource/state_shim_test.go +++ b/helper/resource/state_shim_test.go @@ -31,7 +31,7 @@ func TestStateShim(t *testing.T) { Status: states.ObjectReady, AttrsFlat: map[string]string{"id": "foo", "bazzle": "dazzle"}, SchemaVersion: 7, - Dependencies: []addrs.Referenceable{ + DependsOn: []addrs.Referenceable{ addrs.ResourceInstance{ Resource: addrs.Resource{ Mode: 'M', @@ -52,9 +52,9 @@ func TestStateShim(t *testing.T) { Name: "baz", }.Instance(addrs.NoKey), &states.ResourceInstanceObjectSrc{ - Status: states.ObjectReady, - AttrsFlat: map[string]string{"id": "baz", "bazzle": "dazzle"}, - Dependencies: []addrs.Referenceable{}, + Status: states.ObjectReady, + AttrsFlat: map[string]string{"id": "baz", "bazzle": "dazzle"}, + DependsOn: []addrs.Referenceable{}, }, addrs.ProviderConfig{ Type: "test", @@ -70,9 +70,9 @@ func TestStateShim(t *testing.T) { Name: "foo", }.Instance(addrs.NoKey), &states.ResourceInstanceObjectSrc{ - Status: states.ObjectReady, - AttrsJSON: []byte(`{"id": "bar", "fuzzle":"wuzzle"}`), - Dependencies: []addrs.Referenceable{}, + Status: states.ObjectReady, + AttrsJSON: []byte(`{"id": "bar", "fuzzle":"wuzzle"}`), + DependsOn: []addrs.Referenceable{}, }, addrs.ProviderConfig{ Type: "test", @@ -87,7 +87,7 @@ func TestStateShim(t *testing.T) { &states.ResourceInstanceObjectSrc{ Status: states.ObjectReady, AttrsJSON: []byte(`{"id": "bar", "fizzle":"wizzle"}`), - Dependencies: []addrs.Referenceable{ + DependsOn: []addrs.Referenceable{ addrs.ResourceInstance{ Resource: addrs.Resource{ Mode: 'D', @@ -112,7 +112,7 @@ func TestStateShim(t *testing.T) { &states.ResourceInstanceObjectSrc{ Status: states.ObjectReady, AttrsFlat: map[string]string{"id": "old", "fizzle": "wizzle"}, - Dependencies: []addrs.Referenceable{ + DependsOn: []addrs.Referenceable{ addrs.ResourceInstance{ Resource: addrs.Resource{ Mode: 'D', @@ -134,9 +134,9 @@ func TestStateShim(t *testing.T) { Name: "lots", }.Instance(addrs.IntKey(0)), &states.ResourceInstanceObjectSrc{ - Status: states.ObjectReady, - AttrsFlat: map[string]string{"id": "0", "bazzle": "dazzle"}, - Dependencies: []addrs.Referenceable{}, + Status: states.ObjectReady, + AttrsFlat: map[string]string{"id": "0", "bazzle": "dazzle"}, + DependsOn: []addrs.Referenceable{}, }, addrs.ProviderConfig{ Type: "test", @@ -149,9 +149,9 @@ func TestStateShim(t *testing.T) { Name: "lots", }.Instance(addrs.IntKey(1)), &states.ResourceInstanceObjectSrc{ - Status: states.ObjectTainted, - AttrsFlat: map[string]string{"id": "1", "bazzle": "dazzle"}, - Dependencies: []addrs.Referenceable{}, + Status: states.ObjectTainted, + AttrsFlat: map[string]string{"id": "1", "bazzle": "dazzle"}, + DependsOn: []addrs.Referenceable{}, }, addrs.ProviderConfig{ Type: "test", @@ -165,9 +165,9 @@ func TestStateShim(t *testing.T) { Name: "single_count", }.Instance(addrs.IntKey(0)), &states.ResourceInstanceObjectSrc{ - Status: states.ObjectReady, - AttrsJSON: []byte(`{"id": "single", "bazzle":"dazzle"}`), - Dependencies: []addrs.Referenceable{}, + Status: states.ObjectReady, + AttrsJSON: []byte(`{"id": "single", "bazzle":"dazzle"}`), + DependsOn: []addrs.Referenceable{}, }, addrs.ProviderConfig{ Type: "test",