From 4006c0fc84ec2b72365014f622b5bebe0db89466 Mon Sep 17 00:00:00 2001
From: James Bardin <j.bardin@gmail.com>
Date: Wed, 13 Mar 2019 19:17:38 -0400
Subject: [PATCH] add test for set value drift

The changed value for the set attribute should be correctly read from
the provider.
---
 builtin/providers/test/resource_test.go | 58 +++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/builtin/providers/test/resource_test.go b/builtin/providers/test/resource_test.go
index d69744772..350a76841 100644
--- a/builtin/providers/test/resource_test.go
+++ b/builtin/providers/test/resource_test.go
@@ -8,6 +8,7 @@ import (
 
 	"github.com/hashicorp/terraform/addrs"
 	"github.com/hashicorp/terraform/helper/resource"
+	"github.com/hashicorp/terraform/helper/schema"
 	"github.com/hashicorp/terraform/terraform"
 )
 
@@ -732,3 +733,60 @@ resource "test_resource" "foo" {
 		},
 	})
 }
+
+func TestResource_setDrift(t *testing.T) {
+	testProvider := testAccProviders["test"]
+	res := testProvider.(*schema.Provider).ResourcesMap["test_resource"]
+
+	// reset the Read function after the test
+	defer func() {
+		res.Read = testResourceRead
+	}()
+
+	resource.UnitTest(t, resource.TestCase{
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckResourceDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: strings.TrimSpace(`
+resource "test_resource" "foo" {
+  required     = "first"
+  required_map = {
+    a = "a"
+	}
+	set = ["a", "b"]
+}
+`),
+				Check: func(s *terraform.State) error {
+					return nil
+				},
+			},
+			resource.TestStep{
+				PreConfig: func() {
+					// update the Read function to return the wrong "set" attribute values.
+					res.Read = func(d *schema.ResourceData, meta interface{}) error {
+						// update as expected first
+						if err := testResourceRead(d, meta); err != nil {
+							return err
+						}
+						d.Set("set", []interface{}{"a", "x"})
+						return nil
+					}
+				},
+				// Leave the config, so we can detect the mismatched set values.
+				// Updating the config would force the test to pass even if the Read
+				// function values were ignored.
+				Config: strings.TrimSpace(`
+resource "test_resource" "foo" {
+  required     = "second"
+  required_map = {
+    a = "a"
+	}
+	set = ["a", "b"]
+}
+`),
+				ExpectNonEmptyPlan: true,
+			},
+		},
+	})
+}