resilien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Service role is not updated on AWS for a CodeDeploy deployment group (#9866) 

Service role is not updated on AWS for a CodeDeploy deployment group
This commit is contained in:
Andras Ferencz-Szabo 2016-12-07 12:34:58 +00:00 committed by Paul Stack
parent 658f048ca4
commit 53ebbed8df
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
builtin/providers/aws/resource_aws_codedeploy_deployment_group.go
View File

@ -336,6 +336,7 @@ func resourceAwsCodeDeployDeploymentGroupUpdate(d *schema.ResourceData, meta int
input := codedeploy.UpdateDeploymentGroupInput{
ApplicationName: aws.String(d.Get("app_name").(string)),
CurrentDeploymentGroupName: aws.String(d.Get("deployment_group_name").(string)),
ServiceRoleArn: aws.String(d.Get("service_role_arn").(string)),
}
if d.HasChange("autoscaling_groups") {

14
builtin/providers/aws/resource_aws_codedeploy_deployment_group_test.go
View File

@ -37,6 +37,9 @@ func TestAccAWSCodeDeployDeploymentGroup_basic(t *testing.T) {
"aws_codedeploy_deployment_group.foo", "deployment_group_name", "foo_"+rName),
resource.TestCheckResourceAttr(
"aws_codedeploy_deployment_group.foo", "deployment_config_name", "CodeDeployDefault.OneAtATime"),
resource.TestMatchResourceAttr(
"aws_codedeploy_deployment_group.foo", "service_role_arn",
regexp.MustCompile("arn:aws:iam::[0-9]{12}:role/foo_role_.*")),
resource.TestCheckResourceAttr(
"aws_codedeploy_deployment_group.foo", "ec2_tag_filter.#", "1"),
@ -65,6 +68,9 @@ func TestAccAWSCodeDeployDeploymentGroup_basic(t *testing.T) {
"aws_codedeploy_deployment_group.foo", "deployment_group_name", "bar_"+rName),
resource.TestCheckResourceAttr(
"aws_codedeploy_deployment_group.foo", "deployment_config_name", "CodeDeployDefault.OneAtATime"),
resource.TestMatchResourceAttr(
"aws_codedeploy_deployment_group.foo", "service_role_arn",
regexp.MustCompile("arn:aws:iam::[0-9]{12}:role/bar_role_.*")),
resource.TestCheckResourceAttr(
"aws_codedeploy_deployment_group.foo", "ec2_tag_filter.#", "1"),
@ -1042,7 +1048,7 @@ resource "aws_codedeploy_app" "foo_app" {
resource "aws_iam_role_policy" "foo_policy" {
name = "foo_policy_%s"
role = "${aws_iam_role.foo_role.id}"
role = "${aws_iam_role.bar_role.id}"
policy = <<EOF
{
"Version": "2012-10-17",
@ -1068,8 +1074,8 @@ resource "aws_iam_role_policy" "foo_policy" {
EOF
}
resource "aws_iam_role" "foo_role" {
name = "foo_role_%s"
resource "aws_iam_role" "bar_role" {
name = "bar_role_%s"
assume_role_policy = <<EOF
{
"Version": "2012-10-17",
@ -1092,7 +1098,7 @@ EOF
resource "aws_codedeploy_deployment_group" "foo" {
app_name = "${aws_codedeploy_app.foo_app.name}"
deployment_group_name = "bar_%s"
service_role_arn = "${aws_iam_role.foo_role.arn}"
service_role_arn = "${aws_iam_role.bar_role.arn}"
ec2_tag_filter {
key = "filterkey"
type = "KEY_AND_VALUE"