From 5ed7d172652dfbe0f83a8bcb7a0dc4471b805fac Mon Sep 17 00:00:00 2001 From: James Bardin Date: Thu, 21 Nov 2019 10:34:22 -0500 Subject: [PATCH] remove incorrect comment The CreateBeforeDestroy transformer correctly handles the edge referred to in the comment, and going forward it will probably be easier to use the knowledge of this edge for CBD anyway. --- terraform/transform_destroy_edge.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/terraform/transform_destroy_edge.go b/terraform/transform_destroy_edge.go index bc3c9619d..f52429229 100644 --- a/terraform/transform_destroy_edge.go +++ b/terraform/transform_destroy_edge.go @@ -122,12 +122,6 @@ func (t *DestroyEdgeTransformer) Transform(g *Graph) error { for _, resAddr := range ri.StateDependencies() { for _, desDep := range destroyersByResource[resAddr.String()] { - // TODO: don't connect this if c is CreateBeforeDestroy. - // This will require getting the actual change action at - // this point, since the lifecycle may have been forced - // by a dependent. This should prevent needing to prune - // the edge back out in CBDEdgeTransformer, and allow - // non-CBD nodes to depend on CBD destroys directly. log.Printf("[TRACE] DestroyEdgeTransformer: %s has stored dependency of %s\n", dag.VertexName(c), dag.VertexName(desDep)) g.Connect(dag.BasicEdge(c, desDep))