From 757217b91f911423aed907f9a416257445f29dcf Mon Sep 17 00:00:00 2001
From: Mitchell Hashimoto <mitchell.hashimoto@gmail.com>
Date: Fri, 17 Feb 2017 13:13:44 -0800
Subject: [PATCH] terraform: destroy resource should depend on destroy-time
 prov deps

---
 terraform/context_apply_test.go               | 62 +++++++++++++++++++
 terraform/node_resource_destroy.go            | 15 +++++
 .../child/main.tf                             | 10 +++
 .../apply-provisioner-destroy-module/main.tf  |  4 ++
 4 files changed, 91 insertions(+)
 create mode 100644 terraform/test-fixtures/apply-provisioner-destroy-module/child/main.tf
 create mode 100644 terraform/test-fixtures/apply-provisioner-destroy-module/main.tf

diff --git a/terraform/context_apply_test.go b/terraform/context_apply_test.go
index cab3e986f..15af89edc 100644
--- a/terraform/context_apply_test.go
+++ b/terraform/context_apply_test.go
@@ -4639,6 +4639,68 @@ aws_instance.foo:
 	}
 }
 
+func TestContext2Apply_provisionerDestroyModule(t *testing.T) {
+	m := testModule(t, "apply-provisioner-destroy-module")
+	p := testProvider("aws")
+	pr := testProvisioner()
+	p.ApplyFn = testApplyFn
+	p.DiffFn = testDiffFn
+	pr.ApplyFn = func(rs *InstanceState, c *ResourceConfig) error {
+		val, ok := c.Config["foo"]
+		if !ok || val != "value" {
+			t.Fatalf("bad value for foo: %v %#v", val, c)
+		}
+
+		return nil
+	}
+
+	state := &State{
+		Modules: []*ModuleState{
+			&ModuleState{
+				Path: []string{"root", "child"},
+				Resources: map[string]*ResourceState{
+					"aws_instance.foo": &ResourceState{
+						Type: "aws_instance",
+						Primary: &InstanceState{
+							ID: "bar",
+						},
+					},
+				},
+			},
+		},
+	}
+
+	ctx := testContext2(t, &ContextOpts{
+		Module:  m,
+		State:   state,
+		Destroy: true,
+		Providers: map[string]ResourceProviderFactory{
+			"aws": testProviderFuncFixed(p),
+		},
+		Provisioners: map[string]ResourceProvisionerFactory{
+			"shell": testProvisionerFuncFixed(pr),
+		},
+	})
+
+	if _, err := ctx.Plan(); err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	state, err := ctx.Apply()
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	checkStateString(t, state, `
+module.child:
+  <no state>`)
+
+	// Verify apply was invoked
+	if !pr.ApplyCalled {
+		t.Fatalf("provisioner not invoked")
+	}
+}
+
 func TestContext2Apply_provisionerResourceRef(t *testing.T) {
 	m := testModule(t, "apply-provisioner-resource-ref")
 	p := testProvider("aws")
diff --git a/terraform/node_resource_destroy.go b/terraform/node_resource_destroy.go
index 9a0bc8c2d..c2efd2c38 100644
--- a/terraform/node_resource_destroy.go
+++ b/terraform/node_resource_destroy.go
@@ -68,6 +68,21 @@ func (n *NodeDestroyResource) ReferenceableName() []string {
 
 // GraphNodeReferencer, overriding NodeAbstractResource
 func (n *NodeDestroyResource) References() []string {
+	// If we have a config, then we need to include destroy-time dependencies
+	if c := n.Config; c != nil {
+		var result []string
+		for _, p := range c.Provisioners {
+			// We include conn info and config for destroy time provisioners
+			// as dependencies that we have.
+			if p.When == config.ProvisionerWhenDestroy {
+				result = append(result, ReferencesFromConfig(p.ConnInfo)...)
+				result = append(result, ReferencesFromConfig(p.RawConfig)...)
+			}
+		}
+
+		return result
+	}
+
 	return nil
 }
 
diff --git a/terraform/test-fixtures/apply-provisioner-destroy-module/child/main.tf b/terraform/test-fixtures/apply-provisioner-destroy-module/child/main.tf
new file mode 100644
index 000000000..f91f2b261
--- /dev/null
+++ b/terraform/test-fixtures/apply-provisioner-destroy-module/child/main.tf
@@ -0,0 +1,10 @@
+variable "key" {}
+
+resource "aws_instance" "foo" {
+    foo = "bar"
+
+    provisioner "shell" {
+        foo  = "${var.key}"
+        when = "destroy"
+    }
+}
diff --git a/terraform/test-fixtures/apply-provisioner-destroy-module/main.tf b/terraform/test-fixtures/apply-provisioner-destroy-module/main.tf
new file mode 100644
index 000000000..817ae043d
--- /dev/null
+++ b/terraform/test-fixtures/apply-provisioner-destroy-module/main.tf
@@ -0,0 +1,4 @@
+module "child" {
+    source = "./child"
+    key    = "value"
+}