From 7e4f09c7871cfff3e54555185f2de9d0e86df1ef Mon Sep 17 00:00:00 2001 From: James Bardin Date: Thu, 1 Nov 2018 16:14:23 -0400 Subject: [PATCH] don't apply unchanged attributes from legacy diffs If a legacy diff has equal old and new values, don't apply the diff. These would show up in sets, because of the overall change in set key. --- terraform/diff.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/terraform/diff.go b/terraform/diff.go index 1ac43910e..92b575086 100644 --- a/terraform/diff.go +++ b/terraform/diff.go @@ -457,6 +457,11 @@ func (d *InstanceDiff) ApplyToValue(base cty.Value, schema *configschema.Block) continue } + // sometimes helper/schema gives us values that aren't really a diff + if diff.Old == diff.New { + continue + } + attrs[attr] = diff.New }