provider/ns1: No splitting answer on spf records. (#13260)
* provider/ns1: No splitting answer on spf records. * provider/ns1: Adds acctest for SPF records.
This commit is contained in:
parent
e885ab81a8
commit
8e87b107a9
|
@ -236,7 +236,7 @@ func resourceDataToRecord(r *dns.Record, d *schema.ResourceData) error {
|
||||||
var a *dns.Answer
|
var a *dns.Answer
|
||||||
v := answer["answer"].(string)
|
v := answer["answer"].(string)
|
||||||
switch d.Get("type") {
|
switch d.Get("type") {
|
||||||
case "TXT":
|
case "TXT", "SPF":
|
||||||
a = dns.NewTXTAnswer(v)
|
a = dns.NewTXTAnswer(v)
|
||||||
default:
|
default:
|
||||||
a = dns.NewAnswer(strings.Split(v, " "))
|
a = dns.NewAnswer(strings.Split(v, " "))
|
||||||
|
|
|
@ -71,6 +71,27 @@ func TestAccRecord_updated(t *testing.T) {
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestAccRecord_SPF(t *testing.T) {
|
||||||
|
var record dns.Record
|
||||||
|
resource.Test(t, resource.TestCase{
|
||||||
|
PreCheck: func() { testAccPreCheck(t) },
|
||||||
|
Providers: testAccProviders,
|
||||||
|
CheckDestroy: testAccCheckRecordDestroy,
|
||||||
|
Steps: []resource.TestStep{
|
||||||
|
resource.TestStep{
|
||||||
|
Config: testAccRecordSPF,
|
||||||
|
Check: resource.ComposeTestCheckFunc(
|
||||||
|
testAccCheckRecordExists("ns1_record.spf", &record),
|
||||||
|
testAccCheckRecordDomain(&record, "terraform-record-test.io"),
|
||||||
|
testAccCheckRecordTTL(&record, 86400),
|
||||||
|
testAccCheckRecordUseClientSubnet(&record, true),
|
||||||
|
testAccCheckRecordAnswerRdata(&record, "v=DKIM1; k=rsa; p=XXXXXXXX"),
|
||||||
|
),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
func testAccCheckRecordExists(n string, record *dns.Record) resource.TestCheckFunc {
|
func testAccCheckRecordExists(n string, record *dns.Record) resource.TestCheckFunc {
|
||||||
return func(s *terraform.State) error {
|
return func(s *terraform.State) error {
|
||||||
rs, ok := s.RootModule().Resources[n]
|
rs, ok := s.RootModule().Resources[n]
|
||||||
|
@ -297,3 +318,20 @@ resource "ns1_zone" "test" {
|
||||||
zone = "terraform-record-test.io"
|
zone = "terraform-record-test.io"
|
||||||
}
|
}
|
||||||
`
|
`
|
||||||
|
|
||||||
|
const testAccRecordSPF = `
|
||||||
|
resource "ns1_record" "spf" {
|
||||||
|
zone = "${ns1_zone.test.zone}"
|
||||||
|
domain = "${ns1_zone.test.zone}"
|
||||||
|
type = "SPF"
|
||||||
|
ttl = 86400
|
||||||
|
use_client_subnet = "true"
|
||||||
|
answers = {
|
||||||
|
answer = "v=DKIM1; k=rsa; p=XXXXXXXX"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
resource "ns1_zone" "test" {
|
||||||
|
zone = "terraform-record-test.io"
|
||||||
|
}
|
||||||
|
`
|
||||||
|
|
Loading…
Reference in New Issue