From 95367bc0fceb0a54abccdbf85ebea40ea7d562c6 Mon Sep 17 00:00:00 2001 From: Radek Simko Date: Wed, 23 Dec 2015 10:17:52 +0100 Subject: [PATCH] aws: Fix CheckDestroy for ecs service --- .../providers/aws/resource_aws_ecs_service_test.go | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/builtin/providers/aws/resource_aws_ecs_service_test.go b/builtin/providers/aws/resource_aws_ecs_service_test.go index 9eb9bce18..738741287 100644 --- a/builtin/providers/aws/resource_aws_ecs_service_test.go +++ b/builtin/providers/aws/resource_aws_ecs_service_test.go @@ -209,6 +209,7 @@ func testAccCheckAWSEcsServiceDestroy(s *terraform.State) error { out, err := conn.DescribeServices(&ecs.DescribeServicesInput{ Services: []*string{aws.String(rs.Primary.ID)}, + Cluster: aws.String(rs.Primary.Attributes["cluster"]), }) if awserr, ok := err.(awserr.Error); ok && awserr.Code() == "ClusterNotFoundException" { @@ -217,8 +218,19 @@ func testAccCheckAWSEcsServiceDestroy(s *terraform.State) error { if err == nil { if len(out.Services) > 0 { - return fmt.Errorf("ECS service still exists:\n%#v", out.Services) + var activeServices []*ecs.Service + for _, svc := range out.Services { + if *svc.Status != "INACTIVE" { + activeServices = append(activeServices, svc) + } + } + if len(activeServices) == 0 { + return nil + } + + return fmt.Errorf("ECS service still exists:\n%#v", activeServices) } + return nil } return err