From 9a876f65bad16eb8683b2b74cf53655e64d57aeb Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Wed, 12 Oct 2016 19:01:02 +0800 Subject: [PATCH] terraform: compare diffs on shadow Apply --- terraform/shadow_resource_provider.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/terraform/shadow_resource_provider.go b/terraform/shadow_resource_provider.go index 0355bd78e..967817597 100644 --- a/terraform/shadow_resource_provider.go +++ b/terraform/shadow_resource_provider.go @@ -523,7 +523,13 @@ func (p *shadowResourceProviderShadow) Apply( p.ErrorLock.Unlock() } - // TODO: compare diffs + if !diff.Equal(result.Diff) { + p.ErrorLock.Lock() + p.Error = multierror.Append(p.Error, fmt.Errorf( + "Apply: unequal diffs (real, then shadow):\n\n%#v\n\n%#v", + result.Diff, diff)) + p.ErrorLock.Unlock() + } return result.Result, result.ResultErr }