Merge pull request #10318 from hashicorp/b-ds-prov

config: validate that data sources don't have provisioners

config/config.go

@@ -610,6 +610,15 @@ func (c *Config) Validate() error {
 				"%s: lifecycle ignore_changes cannot contain interpolations",
 				n))
 		}
+
+		// If it is a data source then it can't have provisioners
+		if r.Mode == DataResourceMode {
+			if _, ok := r.RawConfig.Raw["provisioner"]; ok {
+				errs = append(errs, fmt.Errorf(
+					"%s: data sources cannot have provisioners",
+					n))
+			}
+		}
 	}
 
 	for source, vs := range vars {

config/config_test.go

@@ -161,6 +161,13 @@ func TestConfigValidate_table(t *testing.T) {
 			true,
 			"non-existent module 'foo'",
 		},
+
+		{
+			"data source with provisioners",
+			"validate-data-provisioner",
+			true,
+			"data sources cannot have",
+		},
 	}
 
 	for i, tc := range cases {

config/test-fixtures/validate-data-provisioner/main.tf

@@ -0,0 +1,3 @@
+data "foo" "bar" {
+  provisioner "local-exec" {}
+}