terraform: validate providers even without config block [GH-284]

CHANGELOG.md

@@ -1,6 +1,8 @@
 ## 0.2.3 (unreleased)
 
+BUG FIXES:
 
+  * core: Providers are validated even without a `provider` block. [GH-284]
 
 ## 0.2.2 (September 9, 2014)
 

terraform/context.go

@@ -933,11 +933,12 @@ func (c *Context) validateWalkFn(rws *[]string, res *[]error) depgraph.WalkFunc
 			}
 
 		case *GraphNodeResourceProvider:
-			if rn.Config == nil {
-				return nil
+			var raw *config.RawConfig
+			if rn.Config != nil {
+				raw = rn.Config.RawConfig
 			}
 
-			rc := NewResourceConfig(rn.Config.RawConfig)
+			rc := NewResourceConfig(raw)
 
 			for k, p := range rn.Providers {
 				log.Printf("[INFO] Validating provider: %s", k)

terraform/context_test.go

@@ -121,6 +121,27 @@ func TestContextValidate_providerConfig_bad(t *testing.T) {
 	}
 }
 
+func TestContextValidate_providerConfig_badEmpty(t *testing.T) {
+	config := testConfig(t, "validate-bad-pc-empty")
+	p := testProvider("aws")
+	c := testContext(t, &ContextOpts{
+		Config: config,
+		Providers: map[string]ResourceProviderFactory{
+			"aws": testProviderFuncFixed(p),
+		},
+	})
+
+	p.ValidateReturnErrors = []error{fmt.Errorf("bad")}
+
+	w, e := c.Validate()
+	if len(w) > 0 {
+		t.Fatalf("bad: %#v", w)
+	}
+	if len(e) == 0 {
+		t.Fatalf("bad: %#v", e)
+	}
+}
+
 func TestContextValidate_providerConfig_good(t *testing.T) {
 	config := testConfig(t, "validate-bad-pc")
 	p := testProvider("aws")

terraform/test-fixtures/validate-bad-pc-empty/main.tf

@@ -0,0 +1 @@
+resource "aws_instance" "test" {}