From da12ed640ad5cc34a65499aece98a7e4808a03fd Mon Sep 17 00:00:00 2001 From: Andreas Kyrris Date: Tue, 18 Oct 2016 09:26:31 +0100 Subject: [PATCH] Checking for azure credentials isn't required. The check for ARM_SUBSCRIPTION_ID breaks the PR testing. The PR testing isn't trying to check acceptance tests anyway. There will still be a correct failure for missing ARM_SUBSCRIPTION_ID when running the acceptance test due to the later testAccPreCheck(). --- .../resource_arm_loadbalancer_backend_address_pool_test.go | 1 - .../providers/azurerm/resource_arm_loadbalancer_nat_pool_test.go | 1 - .../providers/azurerm/resource_arm_loadbalancer_nat_rule_test.go | 1 - .../providers/azurerm/resource_arm_loadbalancer_probe_test.go | 1 - builtin/providers/azurerm/resource_arm_loadbalancer_rule_test.go | 1 - 5 files changed, 5 deletions(-) diff --git a/builtin/providers/azurerm/resource_arm_loadbalancer_backend_address_pool_test.go b/builtin/providers/azurerm/resource_arm_loadbalancer_backend_address_pool_test.go index ddd9880dd..367f15b20 100644 --- a/builtin/providers/azurerm/resource_arm_loadbalancer_backend_address_pool_test.go +++ b/builtin/providers/azurerm/resource_arm_loadbalancer_backend_address_pool_test.go @@ -16,7 +16,6 @@ func TestAccAzureRMLoadBalancerBackEndAddressPool_basic(t *testing.T) { ri := acctest.RandInt() addressPoolName := fmt.Sprintf("%d-address-pool", ri) - testAccPreCheck(t) subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID") backendAddressPool_id := fmt.Sprintf( "/subscriptions/%s/resourceGroups/acctestrg-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/backendAddressPools/%s", diff --git a/builtin/providers/azurerm/resource_arm_loadbalancer_nat_pool_test.go b/builtin/providers/azurerm/resource_arm_loadbalancer_nat_pool_test.go index 0423d9e51..54f719c73 100644 --- a/builtin/providers/azurerm/resource_arm_loadbalancer_nat_pool_test.go +++ b/builtin/providers/azurerm/resource_arm_loadbalancer_nat_pool_test.go @@ -16,7 +16,6 @@ func TestAccAzureRMLoadBalancerNatPool_basic(t *testing.T) { ri := acctest.RandInt() natPoolName := fmt.Sprintf("NatPool-%d", ri) - testAccPreCheck(t) subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID") natPool_id := fmt.Sprintf( "/subscriptions/%s/resourceGroups/acctestrg-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/inboundNatPools/%s", diff --git a/builtin/providers/azurerm/resource_arm_loadbalancer_nat_rule_test.go b/builtin/providers/azurerm/resource_arm_loadbalancer_nat_rule_test.go index 956f5f861..1cb72c3c2 100644 --- a/builtin/providers/azurerm/resource_arm_loadbalancer_nat_rule_test.go +++ b/builtin/providers/azurerm/resource_arm_loadbalancer_nat_rule_test.go @@ -16,7 +16,6 @@ func TestAccAzureRMLoadBalancerNatRule_basic(t *testing.T) { ri := acctest.RandInt() natRuleName := fmt.Sprintf("NatRule-%d", ri) - testAccPreCheck(t) subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID") natRule_id := fmt.Sprintf( "/subscriptions/%s/resourceGroups/acctestrg-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/inboundNatRules/%s", diff --git a/builtin/providers/azurerm/resource_arm_loadbalancer_probe_test.go b/builtin/providers/azurerm/resource_arm_loadbalancer_probe_test.go index 2bb9f3c32..f0a9e045d 100644 --- a/builtin/providers/azurerm/resource_arm_loadbalancer_probe_test.go +++ b/builtin/providers/azurerm/resource_arm_loadbalancer_probe_test.go @@ -16,7 +16,6 @@ func TestAccAzureRMLoadBalancerProbe_basic(t *testing.T) { ri := acctest.RandInt() probeName := fmt.Sprintf("probe-%d", ri) - testAccPreCheck(t) subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID") probe_id := fmt.Sprintf( "/subscriptions/%s/resourceGroups/acctestrg-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/probes/%s", diff --git a/builtin/providers/azurerm/resource_arm_loadbalancer_rule_test.go b/builtin/providers/azurerm/resource_arm_loadbalancer_rule_test.go index a692f76c9..482444121 100644 --- a/builtin/providers/azurerm/resource_arm_loadbalancer_rule_test.go +++ b/builtin/providers/azurerm/resource_arm_loadbalancer_rule_test.go @@ -64,7 +64,6 @@ func TestAccAzureRMLoadBalancerRule_basic(t *testing.T) { ri := acctest.RandInt() lbRuleName := fmt.Sprintf("LbRule-%s", acctest.RandStringFromCharSet(8, acctest.CharSetAlpha)) - testAccPreCheck(t) subscriptionID := os.Getenv("ARM_SUBSCRIPTION_ID") lbRule_id := fmt.Sprintf( "/subscriptions/%s/resourceGroups/acctestrg-%d/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-%d/loadBalancingRules/%s",