From e08422511e32445ec43e39de9406d7cddde00e0e Mon Sep 17 00:00:00 2001
From: James Bardin <j.bardin@gmail.com>
Date: Tue, 1 Dec 2020 16:09:08 -0500
Subject: [PATCH] lang/funcs: staticcheck

---
 lang/funcs/collection.go | 38 --------------------------------------
 lang/funcs/defaults.go   |  2 --
 lang/functions.go        |  9 ---------
 3 files changed, 49 deletions(-)

diff --git a/lang/funcs/collection.go b/lang/funcs/collection.go
index 0b5922cb1..6b8d1e6bb 100644
--- a/lang/funcs/collection.go
+++ b/lang/funcs/collection.go
@@ -196,30 +196,6 @@ var IndexFunc = function.New(&function.Spec{
 	},
 })
 
-// Flatten until it's not a cty.List, and return whether the value is known.
-// We can flatten lists with unknown values, as long as they are not
-// lists themselves.
-func flattener(flattenList cty.Value) ([]cty.Value, bool) {
-	out := make([]cty.Value, 0)
-	for it := flattenList.ElementIterator(); it.Next(); {
-		_, val := it.Element()
-		if val.Type().IsListType() || val.Type().IsSetType() || val.Type().IsTupleType() {
-			if !val.IsKnown() {
-				return out, false
-			}
-
-			res, known := flattener(val)
-			if !known {
-				return res, known
-			}
-			out = append(out, res...)
-		} else {
-			out = append(out, val)
-		}
-	}
-	return out, true
-}
-
 // LookupFunc constructs a function that performs dynamic lookups of map types.
 var LookupFunc = function.New(&function.Spec{
 	Params: []function.Parameter{
@@ -537,20 +513,6 @@ var MapFunc = function.New(&function.Spec{
 	},
 })
 
-// helper function to add an element to a list, if it does not already exist
-func appendIfMissing(slice []cty.Value, element cty.Value) ([]cty.Value, error) {
-	for _, ele := range slice {
-		eq, err := stdlib.Equal(ele, element)
-		if err != nil {
-			return slice, err
-		}
-		if eq.True() {
-			return slice, nil
-		}
-	}
-	return append(slice, element), nil
-}
-
 // Length returns the number of elements in the given collection or number of
 // Unicode characters in the given string.
 func Length(collection cty.Value) (cty.Value, error) {
diff --git a/lang/funcs/defaults.go b/lang/funcs/defaults.go
index 34d4a0275..0366ea661 100644
--- a/lang/funcs/defaults.go
+++ b/lang/funcs/defaults.go
@@ -68,8 +68,6 @@ var DefaultsFunc = function.New(&function.Spec{
 })
 
 func defaultsApply(input, fallback cty.Value) cty.Value {
-	const fallbackArgIdx = 1
-
 	wantTy := input.Type()
 	if !(input.IsKnown() && fallback.IsKnown()) {
 		return cty.UnknownVal(wantTy)
diff --git a/lang/functions.go b/lang/functions.go
index 905b00f41..3a604f7c5 100644
--- a/lang/functions.go
+++ b/lang/functions.go
@@ -162,15 +162,6 @@ func (s *Scope) Functions() map[string]function.Function {
 	return s.funcs
 }
 
-var unimplFunc = function.New(&function.Spec{
-	Type: func([]cty.Value) (cty.Type, error) {
-		return cty.DynamicPseudoType, fmt.Errorf("function not yet implemented")
-	},
-	Impl: func([]cty.Value, cty.Type) (cty.Value, error) {
-		return cty.DynamicVal, fmt.Errorf("function not yet implemented")
-	},
-})
-
 // experimentalFunction checks whether the given experiment is enabled for
 // the recieving scope. If so, it will return the given function verbatim.
 // If not, it will return a placeholder function that just returns an