fix show-json test to expect error from nested mod

One of the show json command tests expected no error when presented with
an invalid configuration in a nested module. Modify the test created in
PR #21569 so that it can still verify there is no panic, but now expect
an error from init.

command/show_test.go

@@ -5,6 +5,7 @@ import (
 	"io/ioutil"
 	"os"
 	"path/filepath"
+	"strings"
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
@@ -153,6 +154,8 @@ func TestShow_json_output(t *testing.T) {
 			defer os.RemoveAll(td)
 			defer testChdir(t, td)()
 
+			expectError := strings.Contains(entry.Name(), "error")
+
 			p := showFixtureProvider()
 			ui := new(cli.MockUi)
 			m := Meta{
@@ -171,6 +174,10 @@ func TestShow_json_output(t *testing.T) {
 				},
 			}
 			if code := ic.Run([]string{}); code != 0 {
+				if expectError {
+					// this should error, but not panic.
+					return
+				}
 				t.Fatalf("init failed\n%s", ui.ErrorWriter)
 			}
 

command/testdata/show-json/nested-module-error/main.tf

@@ -0,0 +1,3 @@
+module "my_module" {
+  source = "./modules"
+}

command/testdata/show-json/nested-module-error/modules/main.tf

@@ -0,0 +1,3 @@
+module "more" {
+  source = "./more-modules"
+}

command/testdata/show-json/nested-module-error/modules/more-modules/main.tf

@@ -0,0 +1,4 @@
+variable "misspelled" {
+  default     = "ehllo"
+  descriptoni = "I am a misspelled attribute"
+}

command/testdata/show-json/nested-modules/modules/more-modules/main.tf

@@ -1,4 +1,4 @@
-variable "misspelled" {
+variable "ok" {
-  default     = "ehllo"
+  default     = "something"
-  descriptoni = "I am a misspelled attribute"
+  description = "description"
 }

command/testdata/show-json/nested-modules/output.json

@@ -1,23 +1,31 @@
 {
-    "format_version": "0.1",
+  "format_version": "0.1",
-    "terraform_version": "0.12.1-dev",
+  "terraform_version": "0.12.1-dev",
-    "planned_values": {
+  "planned_values": {
-        "root_module": {}
+    "root_module": {}
-    },
+  },
-    "configuration": {
+  "configuration": {
-        "root_module": {
+    "root_module": {
+      "module_calls": {
+        "my_module": {
+          "source": "./modules",
+          "module": {
             "module_calls": {
-                "my_module": {
+              "more": {
-                    "source": "./modules",
+                "module": {
-                    "module": {
+                  "variables": {
-                        "module_calls": {
+                    "ok": {
-                            "more": {
+                      "default": "something",
-                                "module": {}
+                      "description": "description"
-                            }
-                        }
                     }
-                }
+                  }
+                },
+                "source": "./more-modules"
+              }
             }
+          }
         }
+      }
     }
-}
+  }
+}