resilien
/
terraform
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

provider/aws: Add some randomization for this IAM test

This commit is contained in:
clint shryock 2016-02-12 14:38:23 -06:00
parent 9c3699d905
commit e7fa0952de
1 changed files with 30 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
builtin/providers/aws/resource_aws_iam_group_membership_test.go
View File

@ -2,11 +2,13 @@ package aws
import ( import (
"fmt" "fmt"
"strings"
"testing" "testing"
"github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/awserr" "github.com/aws/aws-sdk-go/aws/awserr"
"github.com/aws/aws-sdk-go/service/iam" "github.com/aws/aws-sdk-go/service/iam"
"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource" "github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform" "github.com/hashicorp/terraform/terraform"
) )
@ -14,32 +16,41 @@ import (
func TestAccAWSGroupMembership_basic(t *testing.T) { func TestAccAWSGroupMembership_basic(t *testing.T) {
var group iam.GetGroupOutput var group iam.GetGroupOutput
rString := acctest.RandStringFromCharSet(10, acctest.CharSetAlpha)
configBase := fmt.Sprintf(testAccAWSGroupMemberConfig, rString, rString, rString)
configUpdate := fmt.Sprintf(testAccAWSGroupMemberConfigUpdate, rString, rString, rString, rString)
configUpdateDown := fmt.Sprintf(testAccAWSGroupMemberConfigUpdateDown, rString, rString, rString)
testUser := fmt.Sprintf("test-user-%s", rString)
testUserTwo := fmt.Sprintf("test-user-two-%s", rString)
testUserThree := fmt.Sprintf("test-user-three-%s", rString)
resource.Test(t, resource.TestCase{ resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) }, PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders, Providers: testAccProviders,
CheckDestroy: testAccCheckAWSGroupMembershipDestroy, CheckDestroy: testAccCheckAWSGroupMembershipDestroy,
Steps: []resource.TestStep{ Steps: []resource.TestStep{
resource.TestStep{ resource.TestStep{
Config: testAccAWSGroupMemberConfig, Config: configBase,
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckAWSGroupMembershipExists("aws_iam_group_membership.team", &group), testAccCheckAWSGroupMembershipExists("aws_iam_group_membership.team", &group),
testAccCheckAWSGroupMembershipAttributes(&group, []string{"test-user"}), testAccCheckAWSGroupMembershipAttributes(&group, []string{testUser}),
), ),
}, },
resource.TestStep{ resource.TestStep{
Config: testAccAWSGroupMemberConfigUpdate, Config: configUpdate,
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckAWSGroupMembershipExists("aws_iam_group_membership.team", &group), testAccCheckAWSGroupMembershipExists("aws_iam_group_membership.team", &group),
testAccCheckAWSGroupMembershipAttributes(&group, []string{"test-user-two", "test-user-three"}), testAccCheckAWSGroupMembershipAttributes(&group, []string{testUserTwo, testUserThree}),
), ),
}, },
resource.TestStep{ resource.TestStep{
Config: testAccAWSGroupMemberConfigUpdateDown, Config: configUpdateDown,
Check: resource.ComposeTestCheckFunc( Check: resource.ComposeTestCheckFunc(
testAccCheckAWSGroupMembershipExists("aws_iam_group_membership.team", &group), testAccCheckAWSGroupMembershipExists("aws_iam_group_membership.team", &group),
testAccCheckAWSGroupMembershipAttributes(&group, []string{"test-user-three"}), testAccCheckAWSGroupMembershipAttributes(&group, []string{testUserThree}),
), ),
}, },
}, },
@ -103,8 +114,8 @@ func testAccCheckAWSGroupMembershipExists(n string, g *iam.GetGroupOutput) resou
func testAccCheckAWSGroupMembershipAttributes(group *iam.GetGroupOutput, users []string) resource.TestCheckFunc { func testAccCheckAWSGroupMembershipAttributes(group *iam.GetGroupOutput, users []string) resource.TestCheckFunc {
return func(s *terraform.State) error { return func(s *terraform.State) error {
if *group.Group.GroupName != "test-group" { if !strings.Contains(*group.Group.GroupName, "test-group") {
return fmt.Errorf("Bad group membership: expected %s, got %s", "test-group", *group.Group.GroupName) return fmt.Errorf("Bad group membership: expected %d, got %d", "test-group", *group.Group.GroupName)
} }
uc := len(users) uc := len(users)
@ -125,17 +136,17 @@ func testAccCheckAWSGroupMembershipAttributes(group *iam.GetGroupOutput, users [
const testAccAWSGroupMemberConfig = ` const testAccAWSGroupMemberConfig = `
resource "aws_iam_group" "group" { resource "aws_iam_group" "group" {
name = "test-group" name = "test-group-%s"
path = "/" path = "/"
} }
resource "aws_iam_user" "user" { resource "aws_iam_user" "user" {
name = "test-user" name = "test-user-%s"
path = "/" path = "/"
} }
resource "aws_iam_group_membership" "team" { resource "aws_iam_group_membership" "team" {
name = "tf-testing-group-membership" name = "tf-testing-group-membership-%s"
users = ["${aws_iam_user.user.name}"] users = ["${aws_iam_user.user.name}"]
group = "${aws_iam_group.group.name}" group = "${aws_iam_group.group.name}"
} }
@ -143,27 +154,27 @@ resource "aws_iam_group_membership" "team" {
const testAccAWSGroupMemberConfigUpdate = ` const testAccAWSGroupMemberConfigUpdate = `
resource "aws_iam_group" "group" { resource "aws_iam_group" "group" {
name = "test-group" name = "test-group-%s"
path = "/" path = "/"
} }
resource "aws_iam_user" "user" { resource "aws_iam_user" "user" {
name = "test-user" name = "test-user-%s"
path = "/" path = "/"
} }
resource "aws_iam_user" "user_two" { resource "aws_iam_user" "user_two" {
name = "test-user-two" name = "test-user-two-%s"
path = "/" path = "/"
} }
resource "aws_iam_user" "user_three" { resource "aws_iam_user" "user_three" {
name = "test-user-three" name = "test-user-three-%s"
path = "/" path = "/"
} }
resource "aws_iam_group_membership" "team" { resource "aws_iam_group_membership" "team" {
name = "tf-testing-group-membership" name = "tf-testing-group-membership-%s"
users = [ users = [
"${aws_iam_user.user_two.name}", "${aws_iam_user.user_two.name}",
"${aws_iam_user.user_three.name}", "${aws_iam_user.user_three.name}",
@ -174,17 +185,17 @@ resource "aws_iam_group_membership" "team" {
const testAccAWSGroupMemberConfigUpdateDown = ` const testAccAWSGroupMemberConfigUpdateDown = `
resource "aws_iam_group" "group" { resource "aws_iam_group" "group" {
name = "test-group" name = "test-group-%s"
path = "/" path = "/"
} }
resource "aws_iam_user" "user_three" { resource "aws_iam_user" "user_three" {
name = "test-user-three" name = "test-user-three-%s"
path = "/" path = "/"
} }
resource "aws_iam_group_membership" "team" { resource "aws_iam_group_membership" "team" {
name = "tf-testing-group-membership" name = "tf-testing-group-membership-%s"
users = [ users = [
"${aws_iam_user.user_three.name}", "${aws_iam_user.user_three.name}",
] ]