Commit Graph

1269 Commits

Author SHA1 Message Date
Paul Hinze 6365b3af89 Merge pull request #1515 from hashicorp/b-diff-mismatch-on-instance-replacement
core: avoid diff mismatch on NewRemoved fields during -/+
2015-04-14 17:44:28 -05:00
Paul Hinze 64f0897c82 core: avoid diff mismatch on NewRemoved fields during -/+
fixes #1508

In a DESTROY/CREATE scenario, the plan diff will be run against the
state of the old instance, while the apply diff will be run against an
empty state (because the state is cleared when the destroy node does its
thing.)

For complex attributes, this can result in keys that seem to disappear
between the two diffs, when in reality everything is working just fine.

Same() needs to take into account this scenario by analyzing NewRemoved
and treating as "Same" a diff that does indeed have that key removed.
2015-04-14 17:23:30 -05:00
Mitchell Hashimoto 710d1113eb Merge pull request #1490 from jtopjian/openstack-allow-blank-region
provider/openstack: Allow Blank Region
2015-04-14 08:28:03 -07:00
Mitchell Hashimoto 0eb69bcd37 Merge pull request #1518 from hashicorp/b-lc-id
providers/aws: set LC ID after creation
2015-04-14 08:23:31 -07:00
Mitchell Hashimoto 783d912b7c providers/aws: set id outside if/esle 2015-04-14 08:23:16 -07:00
Clint 0eecf070d9 Merge pull request #1489 from hashicorp/f-aws-upstream-route-table
provider/aws: Convert Route table and Route table association to upstream aws-sdk-go
2015-04-14 10:15:24 -05:00
Clint 85c4a134ad Merge pull request #1486 from hashicorp/f-aws-upstream-vpc
provider/aws: Convert AWS VPC to upstream aws-sdk-go
2015-04-14 10:14:56 -05:00
Mitchell Hashimoto f7a2f2a2e7 providers/aws: set ID after creation 2015-04-13 17:03:13 -07:00
Paul Hinze 86d58089d3 Merge pull request #1509 from hashicorp/f-aws-upstream-network-acl
provider/aws: Convert Network ACL and helper library to upstream aws-sdk-go
2015-04-13 16:48:25 -05:00
Clint Shryock 5394d91657 provider/aws: Convert Network ACL and helper library to upstream aws-sdk-go 2015-04-13 11:14:21 -05:00
Sander van Harmelen 41536c0d58 Reverting the behavioural change, while still fixing the logic error 2015-04-13 17:33:22 +02:00
Clint Shryock 53478c96de provider/aws: Convert AWS Main Route Table Association to upstream 2015-04-13 10:01:56 -05:00
Sander van Harmelen 852e7a3554 Merge pull request #1492 from svanharmelen/f-cloudstack-network
Fixing a small logic error
2015-04-11 17:56:09 +02:00
Sander van Harmelen 8c37a95a5e Fixing a small logic error 2015-04-11 17:53:25 +02:00
Sander van Harmelen 0963d556a3 Refactored the template provider to make it fit in nicely
Fixing a few things while add it and added a additional test as well.
2015-04-11 17:50:06 +02:00
Sander van Harmelen 365251f7a3 Merge pull request #1228 from benjvi/cloudstack-template-resource
provider/cloudstack: added template resource for CloudStack
2015-04-11 17:42:13 +02:00
Joe Topjian fe0a7a5ec5 Allow Blank Region
When OS_REGION_NAME is not set, fall back to a blank string. This
will cause gophercloud to use the cloud's only region in
single-region clouds.
2015-04-11 05:10:10 +00:00
Clint Shryock c89470a754 provider/aws: Convert Route table and Route table association to upstream aws-sdk-go 2015-04-10 17:09:36 -05:00
Clint Shryock 74bab7b89d provider/aws: Convert AWS VPC to upstream aws-sdk-go 2015-04-10 16:09:12 -05:00
Sander van Harmelen 56adfce61f Merge pull request #1481 from svanharmelen/f-cloudstack-connection
provider/cloudstack: adding a few lines to set the connection info
2015-04-10 21:36:39 +02:00
Sander van Harmelen b7a6692548 Adding a few lines to set the connection info 2015-04-10 20:39:52 +02:00
Clint 9f56addf0c Merge pull request #1446 from hashicorp/f-aws-upstream-security-group
providers/aws: Convert AWS Security Group to upstream aws-sdk-go
2015-04-10 11:06:55 -05:00
Clint 7c676f8c91 Merge pull request #1470 from hashicorp/b-aws-fix-credential-detection
provider/aws: Detect creds in AWS config
2015-04-10 10:06:08 -05:00
Paul Hinze 8f5ac1d06f Merge pull request #1458 from sparkprime/fix-network-source
Avoid 'source' being undefined in legacy network Read
2015-04-10 09:34:56 -05:00
Clint Shryock c160058baf provider/aws: Detect creds in AWS config 2015-04-09 17:06:22 -05:00
Clint Shryock 6ff9b0c776 provider/aws: Fix type mismatch issue with AWS RDS 2015-04-09 14:27:52 -05:00
Mitchell Hashimoto 6f82137875 provider/aws: fix potential panic on nil db name [GH-1460] 2015-04-09 11:19:33 -07:00
Mitchell Hashimoto 4e92b8c77f provider/aws: fix network ACL test, at some point we added a second rule 2015-04-09 10:45:22 -07:00
Paul Hinze 1118a86798 providers/aws: make acc test name match pattern 2015-04-09 12:33:20 -05:00
Dave Cunningham d149db41d6 Avoid 'source' being undefined in legacy network Read 2015-04-09 13:29:59 -04:00
Mitchell Hashimoto d189457376 provider/aws: clean up VPC peering connection test 2015-04-09 10:18:50 -07:00
Clint 02c81c479d Merge pull request #1430 from hashicorp/b-aws-route53-record-update
provider/aws: Fix issue in updating Route 53 records on refresh/read.
2015-04-09 11:54:27 -05:00
Mitchell Hashimoto db58c7dd33 providers/docker: default cert_path to non-nil so input isn't asked 2015-04-09 09:49:03 -07:00
Paul Hinze 4363ac4970 Merge pull request #1444 from hashicorp/b-launch-config-bugs
providers/aws: fix a few more bugs in launch configs
2015-04-09 10:24:18 -05:00
Paul Hinze bfb3134148 Merge pull request #1445 from hashicorp/b-ebs-perpetual-recreate-without-both-volume-fields
providers/aws: reduce scope of block_device set hashcodes
2015-04-09 10:24:07 -05:00
Clint Shryock ffdd20133a providers/aws: Convert AWS Security Group to upstream aws-sdk-go
Moves structure test lib too, to that `make test` actually runs it
2015-04-09 09:10:04 -05:00
Clint Shryock ef0a763c29 fix pointer references 2015-04-09 09:03:45 -05:00
Paul Hinze 34c7bbcf4d providers/aws: reduce scope of block_device set hashcodes
Fixes #1409

Resource set hash calculation is a bit of a devil's bargain when it
comes to optional, computed attributes.

If you omit the optional, computed attribute from the hash function,
changing it in an existing config is not properly detected.

If you include the optional, computed attribute in the hash and do not
specify a value for it in the config, then you'll end up with a
perpetual, unresolvable diff.

We'll need to think about how to get the best of both worlds, here, but
for now I'm switching us to the latter and documenting the fact that
changing these attributes requires manual `terraform taint` to apply.
2015-04-09 08:53:09 -05:00
Paul Hinze 8fccd9cec4 providers/aws: fix a few more bugs in launch configs
These bugs were found by additional check added in #1443

 * Reversed nil err check meant that block devices were broken :(
 * Fixing the err check revealed a few missed pointer derefs
 * Unlike instances, ephemeral block devices do come back in
   `BlockDeviceMappings` from `DescribeLaunchConfigurations` calls, so
   we need to recognize them and filter them properly. Even though
   they're not set as computed, I'm doing a `d.Set` since it doesn't
   hurt and it gives us the benefit of basic drift detection.
2015-04-09 08:36:18 -05:00
Radek Simko 947761f34f ec2/config: Use provided region instead of hardcoding us-west-2 2015-04-09 12:36:37 +01:00
Clint 5c3ec3ddcc Merge pull request #1411 from hashicorp/f-aws-upstream-network-interface
provider/aws: Convert AWS Network Interface to aws-sdk-go
2015-04-08 15:51:36 -05:00
Clint 8e25dcd4f6 Merge pull request #1408 from hashicorp/f-aws-upstream-eip
provider/aws: Convert EIP to use upstream aws-sdk-go
2015-04-08 15:51:18 -05:00
Clint 0f6ba3eae9 Merge pull request #1407 from hashicorp/f-aws-upstream-internet-gateway
Convert AWS Internet Gateway to use upstream aws-sdk-go
2015-04-08 15:51:10 -05:00
Clint 281825db76 Merge pull request #1398 from hashicorp/f-aws-upstream-subnet
provider/aws: Convert AWS Subnet to mainstream aws-sdk-go
2015-04-08 15:38:05 -05:00
Clint Shryock 3a5a3d8515 update test to pass on Travis 2015-04-08 15:27:48 -05:00
Clint abdfa450b2 Merge pull request #1397 from hashicorp/aws-upstream-keypair
provider/aws: Convert Key Pair to upstream aws-sdk-go
2015-04-08 15:21:58 -05:00
Clint 28f8dab87f Merge pull request #1396 from hashicorp/f-aws-route53record-add-update
provider/aws: Change Route 53 record to allow resource updates
2015-04-08 15:14:46 -05:00
Paul Hinze 650b9d5542 Merge pull request #1427 from dainis/fix_network_interface_interface
Fix #1394, network value for network_interface
2015-04-08 14:24:20 -05:00
Clint Shryock 22e487c5d0 surface error with setting records on Route 53 record 2015-04-08 14:01:00 -05:00
Clint Shryock 29a5d9fc1a Update how we expand/flatten TXT records for Route 53 2015-04-08 13:58:23 -05:00