Commit Graph

28 Commits

Author SHA1 Message Date
Radek Simko e149a97658 Make composite literals to use keyed fields
This will prevent following error:
 - * composite literal uses unkeyed fields
2015-02-18 18:26:59 +00:00
Mitchell Hashimoto 08813e6571 Merge branch 'add-ig-tags' of https://github.com/robzienert/terraform into robzienert-add-ig-tags
Conflicts:
	builtin/providers/aws/resource_aws_internet_gateway_test.go
2015-01-10 15:28:14 -08:00
Emil Hessman c738bf0477 builtin/providers/aws: remove unreachable code and skip unnecessary remote call
When DeleteInternetGateway is successful it returns a nil error value.
However, for a nil error value, the RetryFunc returns an error yielding a
unnecessary second call to DeleteInternetGateway in the retry logic.

The logic works because DeleteInternetGateway eventually returns an ec2.Error
with error code InvalidInternetGatewayID.NotFound since the internet gateway
has been deleted in the previous call. The return value of nil breaks the
retry logic and the deletion is deemed successful.

Fix the unnecessary second call to DeleteInternetGateway by short circuiting
with a nil error value when deletion of the internet gateway is successful on
the first try.

Add an acceptance test for internet gateway deletion and remove unreachable
code while here.
2015-01-03 21:56:44 +01:00
Rob Zienert 9fd59f09e2 Adding tags support to Internet Gateway resource 2014-12-27 22:05:15 -06:00
Armon Dadgar 6098809ec5 Merge pull request #665 from gosuri/master
Fix for #664, crashed due to ig.Attachements being 0
2014-12-14 18:15:27 -08:00
Greg Osuri 9b9d147585 Setting the VPC id to blank for unattached igws 2014-12-14 14:05:38 -08:00
Sander van Harmelen 27a97c4498 Small gofmt update... 2014-12-14 12:32:17 +01:00
Sander van Harmelen d9af954c60 provider/aws: fixing the aws_internet_gateway resource
The resource is build so it can attach and detach the Internet Gateway
from a VPC, but as the schema has `Required` and `ForceNew` both set
to `true` for the vpc_id field it will never use these capabilities.
2014-12-14 12:20:59 +01:00
Greg Osuri 3883e47902 Fix for #664, crashed due to ig.Attachements being 0 2014-12-13 22:14:23 -08:00
Sander van Harmelen eccd5ad308 Refactored about 90%
Still need to update 2 resources and check the acceptance tests, but
overall we’re nearly there 😃
2014-11-21 17:58:34 +01:00
Panagiotis Moustafellos f240c27e16 providers/aws: retry destroying internet gateway for some time [GH-447] 2014-10-18 11:47:33 +03:00
Mitchell Hashimoto 9b2b3a963f ResourceDiff => InstanceDiff 2014-09-17 16:33:24 -07:00
Mitchell Hashimoto c5d6df692d providers/aws: tests passing, compiles 2014-09-16 17:49:24 -07:00
Mitchell Hashimoto 56cf1e6faa Fix go vet complaints 2014-08-24 21:50:35 -07:00
Mitchell Hashimoto bd2fe4d145 providers/aws: return proper internet gateway when attach fails 2014-07-13 11:16:59 -07:00
Mitchell Hashimoto 9afebeb07e providers/aws: route table tests 2014-07-10 15:52:56 -07:00
Mitchell Hashimoto 265cc4fffa providers/aws: extend InternetGateway timeout to be safe 2014-07-10 15:35:41 -07:00
Mitchell Hashimoto 71b30c633f providers/aws: internetgateway timing tweaks
So I think the AWS API is just broken here. In the case that the state
doesn't update, just assume it did after 5 seconds.
2014-07-10 15:33:50 -07:00
Mitchell Hashimoto a46cafc975 providers/aws: internet gateway is more robust 2014-07-09 09:16:47 -07:00
Mitchell Hashimoto 66c716540f providers/aws: internet gateway delete is more flexible 2014-07-08 16:05:08 -07:00
Mitchell Hashimoto 5bec1ac383 providers/aws: gateway detach is idempotent 2014-07-08 16:02:01 -07:00
Mitchell Hashimoto f7b7c30055 providers/aws: internet gateway belongs to VPC 2014-07-07 21:03:53 -07:00
Mitchell Hashimoto c0dbb8febd providers/aws: much better logic for attaching/detaching internet gateways 2014-07-07 21:00:46 -07:00
Mitchell Hashimoto 037bed71ed providers/aws: support attaching/detaching internet gateway 2014-07-07 20:51:45 -07:00
Mitchell Hashimoto bdc2a53c9d providers/aws: style 2014-07-07 17:12:22 -07:00
Mitchell Hashimoto e33739209b providers/aws: its okay to delete something that is already gone 2014-07-07 17:09:05 -07:00
Mitchell Hashimoto 5b95271819 providers/aws: clean up internet gateway code 2014-07-07 16:14:08 -07:00
Mitchell Hashimoto 42e999923a providers/aws: aws_internet_gateway 2014-07-07 16:12:03 -07:00