Commit Graph

3195 Commits

Author SHA1 Message Date
clint shryock 1c2c1a5edb provider/aws: Update tests destroy checks 2015-12-22 11:08:09 -06:00
clint shryock 84fe0b15fd provider/aws: Update ElastiCache tests to verify delete
provider/aws: update elasticache search domain to only save access policies if not empty
2015-12-22 10:21:40 -06:00
Paul Hinze 88b2b86978 Merge pull request #4416 from hashicorp/phinze/aws-network-acl-fixes
provider/aws: fixes for Network ACL Rules
2015-12-22 10:21:05 -06:00
Paul Hinze df0f65502f provider/aws: fix CheckDestroy on placement_group tests 2015-12-22 10:20:28 -06:00
nextrevision 27b8dd08e7 Check for ecr repository and policy removal 2015-12-22 11:18:14 -05:00
Paul Hinze 7f62a49ebd provider/aws: fixes for Network ACL Rules
* Fixup Exists and CheckDestroy assertions
 * Make ingress/egress computed on network_acl, otherwise you could
   never use network_acl_rule with a managed network_acl without a
   perpetual diff.
2015-12-22 09:58:22 -06:00
nextrevision 6a3ed429ad Adding AWS ECR provider resources
Adds ECR aws_ecr_repository and aws_ecr_repository_policy resources to
the AWS provider.
2015-12-22 10:31:30 -05:00
Paul Hinze b7e87bbf16 provider/aws: fix CheckDestroy for main_route_table_association tests 2015-12-22 09:02:01 -06:00
Paul Hinze c8319d3b72 provider/aws: fix CheckDestroy on aws_instance tests 2015-12-22 08:49:50 -06:00
Paul Hinze fd528df002 provider/aws: fix CheckDestroy for iam_group_policy tests 2015-12-22 08:05:37 -06:00
Paul Hinze c8e88ed1b4 provider/aws: fix CheckDestroy for group_membership test 2015-12-22 08:00:55 -06:00
Paul Hinze da2c545c8c Merge pull request #4370 from TimeIncOSS/b-cloudformation-params-fix
provider/aws: CloudFormation - Use body or URL for all updates
2015-12-22 07:56:23 -06:00
Paul Hinze bf40c48075 provider/aws: fix ELB acc tests
* LB Name test could end up too long and fail
 * CheckDestroy was looking for the wrong error code
2015-12-22 07:41:24 -06:00
Paul Hinze 10cc513ae0 provider/aws: fix CheckDestroy for aws_eip tests 2015-12-22 07:34:06 -06:00
Paul Hinze 51732ac9eb provider/aws: fix CheckDestroy for codedeploy_app tests 2015-12-22 07:22:06 -06:00
Paul Hinze 02f14ae34a provider/aws: fix CheckDestroy on glacier vault 2015-12-22 07:17:35 -06:00
Paul Hinze 7d6b98060a provider/aws: fix CheckDestroy on a bunch of resources 2015-12-21 21:43:42 -06:00
Paul Hinze 1d5c65fa86 provider/aws: fix cookie stickiness policy test destroys 2015-12-21 21:23:57 -06:00
Paul Hinze 67832f6bd0 provider/aws: fix cache SG tests
* CheckDestroy should handle not found error
 * Pin provider in config to region most likely to have EC2 Classic
2015-12-21 21:12:47 -06:00
Paul Hinze 47f8b0cd79 provider/aws: fix ECS service CheckDestroy in tests 2015-12-21 21:10:13 -06:00
Paul Hinze f473c2a6d4 provider/aws: don't set static ELB names in tests
Prevents ELB name collisions during test runs
2015-12-21 17:41:55 -06:00
Paul Hinze 3dd8bea986 provider/aws: route table test; use standard account id env var
also moves the env var check inside the PreCheck, which makes it a
little simpler
2015-12-21 15:09:12 -06:00
Paul Hinze 092c268681 provider/aws: kinesis firehose stream: retry through IAM propagation
As I was fixing up the AccTests to not depend on a single existing IAM
role (which this commit does), I noticed that without some sleeping that
the kinesis_firehose_delivery_stream would often come back with:

```
msg: Firehose is unable to assume role {{arn}}. Please check the role provided.
code: InvalidArgumentException
```

Similar to the strategy taken in aws_instance with IAM Instance Profile errors,
I dropped in a simple retry loop which seemed to take care of the issue. Seems
that the same permission propagation delays apply here too.
2015-12-21 14:46:25 -06:00
Simon Thulbourn 3701342716 Alters template provider to use a fork of multipart.
Signed-off-by: Simon Thulbourn <simon+github@thulbourn.com>
2015-12-21 13:32:26 -05:00
Simon Thulbourn 33d2afc26d Add headers to output
The original implmentation was missing headers to denote mime version &
content transfer encoding, this caused issues with EC2.

Signed-off-by: Simon Thulbourn <simon+github@thulbourn.com>
2015-12-21 13:32:26 -05:00
James Nugent ba9c7323a9 Remove unnecessary commented imports 2015-12-21 13:32:26 -05:00
James Nugent abffa67a49 Rename resource.go -> resource_template_file.go
This is necessitated by new resources being added to the template
provider.
2015-12-21 13:32:26 -05:00
James Nugent a926fa6fdd Adds template_cloudinit_config resource to template
This adds a new resource to template to generate multipart cloudinit
configurations to be used with other providers/resources.

The resource has the ability gzip and base64 encode the parts.
2015-12-21 13:32:26 -05:00
stack72 5fbec544d7 Fixing yet more gofmt errors with imports 2015-12-21 09:54:24 +00:00
stack72 bf03752552 Adding the documentation for the AWS Redshift Subnet Group resource
also removed the notion of tags from the redshift security group and
parameter group documentation until that has been implemented

Redshift Cluster CRUD and acceptance tests

Removing the Acceptance test for the Cluster Updates. You cannot delete
a cluster immediately after performing an operation on it. We would need
to add a lot of retry logic to the system to get this test to work

Adding some schema validation for RedShift cluster

Adding the last of the pieces of a first draft of the Redshift work - this is the documentation
2015-12-20 20:20:05 +00:00
stack72 48091e37c7 Adding the documentation for the Redshift Parameter Groups
Changed the aws_redshift_security_group and aws_redshift_parameter_group
to remove the tags from the schema. Tags are a little bit more
complicated than originally though - I will revisit this later

Then added the schema, CRUD functionality and basic acceptance tests for
aws_redshift_subnet_group

Adding an acceptance test for the Update of subnet_ids in AWS Redshift Subnet Group
2015-12-20 20:20:03 +00:00
stack72 249e7df76c Adding the documentation for the Redshift security groups
Creation of the schema, CRUD and acceptance tests for Redshift Parameter Group
2015-12-20 20:20:01 +00:00
stack72 85afc7d614 Initial creation of the work for AWS RedShift Support
Finalising the schema and acceptance tests for the Redshift Security Group's
2015-12-20 20:19:55 +00:00
James Nugent 27008ae898 Merge pull request #4395 from stack72/gofmt_errors_2
Fix some gofmt errors in imports
2015-12-19 11:47:01 -05:00
stack72 244a75504e More gofmt errors I'm afraid 2015-12-19 16:42:10 +00:00
James Nugent c442ca3899 Merge pull request #4344 from hashicorp/b-aws-s3-test-fixes
provider/aws: Fix check destroy method for s3 tests
2015-12-19 11:41:00 -05:00
stack72 d932d99679 Adds documentation for the AWS Network ACL Rule resource 2015-12-18 23:17:08 +00:00
stack72 96ad95abe9 Adds an acceptance test for the AWS Network ACL Rules 2015-12-18 23:14:54 +00:00
stack72 2df8d7d9b0 Initial Scaffolding of the AWS Network ACL Entry resource 2015-12-18 23:14:54 +00:00
James Nugent 30f9d61a95 Merge pull request #4387 from justnom/master
provider/aws: EIP not noticing it has been unassigned from an ENI
2015-12-18 17:32:55 -05:00
Jesse Szwedko 48bfd67296 Add support for creating connectors to aws_directory_service_directory
This adds support for creating AD Connectors. It is pretty close to the
same as creating AD and simple directories so we reuse the resource.
2015-12-18 21:42:54 +00:00
James Nugent ceee811625 Merge pull request #4381 from hashicorp/f-nat-gateway
provider/aws: Support for aws_nat_gateway
2015-12-18 16:00:42 -05:00
clint shryock 3b21fbc1bc provider/aws: Update VPC Endpoint to correctly set route table ids, and read after update 2015-12-18 14:18:30 -06:00
Clint 058b55635e Merge pull request #4264 from h-imaoka/b-aws-vpce-fix
providers_aws_vpce issue #4137
2015-12-18 14:10:01 -06:00
Jesse Szwedko 2d06381824 Increase aws_directory_service_directory timeouts
According to the AWS docs, creating a MS directory could take up to 25
minutes.
2015-12-18 20:07:34 +00:00
Jesse Szwedko 6bf1011df4 Validate type earlier for aws_directory_service_directory
Also DRY it up a little
2015-12-18 19:56:58 +00:00
Radek Simko b120f8c123 Merge pull request #4372 from TimeIncOSS/b-cf-deleted-fix
provider/aws: Treat CF stacks in DELETE_COMPLETE state as deleted
2015-12-18 20:44:11 +01:00
James Nugent 0bdf249f2c provider/aws: Add aws_nat_gateway Resource 2015-12-18 14:12:27 -05:00
Jesse Szwedko 82fe67f7fc Add support for creating Managed Microsoft Active Directory in AWS
This action is almost exactly the same as creating a SimpleAD so we
reuse this resource and allow the user to specify the type when creating
the directory (ignoring the size if the type is MicrosoftAD).
2015-12-18 18:24:51 +00:00
Martin Atkins e971688151 Merge pull request #4301 from apparentlymart/rundeck-task-project-issue
Only refresh project name if Rundeck server provides it
2015-12-18 09:43:48 -08:00
Clint e273fe6cfc Merge pull request #3663 from semarj/master
get profile name even if profile path exists
2015-12-18 10:55:23 -06:00
James Nugent 8e538b68ec Fix errors with gofmt compliance 2015-12-17 12:35:19 -05:00
Radek Simko 4e408d1593 provider/aws: CloudFormation - Add regression test for #4332 2015-12-17 18:00:09 +01:00
Radek Simko f017d2d2d6 aws: Treat CF stacks in DELETE_COMPLETE state as deleted 2015-12-17 17:59:38 +01:00
Radek Simko 8b30fd484d Merge pull request #4365 from TimeIncOSS/b-ecs-td-fix
provider/aws: Treat INACTIVE ECS TDs as deleted in acc tests
2015-12-17 17:38:46 +01:00
Radek Simko 202b0aef1b provider/aws: Always use either body or URL for all updates
- fixes #4332
2015-12-17 17:01:34 +01:00
Radek Simko a080447471 aws: Treat INACTIVE ECS TDs as deleted in acc tests
- related to https://github.com/hashicorp/terraform/pull/3924
2015-12-17 15:40:27 +01:00
Radek Simko 7f5e2b66ff aws: Treat INACTIVE ECS cluster as deleted 2015-12-17 15:34:49 +01:00
Joe Topjian 669ddbfc5c Merge pull request #4288 from jtopjian/jtopjian-openstack-bfv-set2list
provider/openstack: Convert block_device from TypeSet to TypeList
2015-12-16 23:05:00 -07:00
Martin Atkins a9d97708ee mysql provider and mysql_database resource.
Allows databases on pre-existing MySQL servers to be created and managed
by Terraform.
2015-12-16 17:59:35 -08:00
stack72 14b7559cd1 Fixing Gofmt errors 2015-12-17 00:43:50 +01:00
Harry Macey 4f5df717b4 Fixes #4351
Adding empty string defaults for network interface and instance when reading `aws_eip` resource.
2015-12-16 17:38:05 -05:00
clint shryock d4e4fb6ea0 Reuse structure method for network interface ips 2015-12-16 13:56:23 -06:00
Joe Topjian 03a7926198 Merge pull request #4298 from jtopjian/jtopjian-openstack-devstack
provider/openstack: DevStack Deploy Script
2015-12-16 11:44:12 -07:00
Clint fb2735e470 Merge pull request #4307 from justnom/b-private-ips-eni
provider/aws: Allow changing private IPs for ENIs
2015-12-16 11:43:07 -06:00
Clint 60817ae91a Merge pull request #4315 from paybyphone/paybyphone_s3bucketpolicywaiter
aws_s3_bucket: Retry MalformedPolicy errors due to newly created principals
2015-12-16 11:21:52 -06:00
clint shryock b172d94381 provider/aws: Fix check destroy method for s3 tests 2015-12-16 11:07:15 -06:00
James Nugent 19e68da388 Merge pull request #4340 from stack72/f-aws-db_subnet_group_name-downcase
provider/aws: StateFunc on db_subnet_group name to be lowercase
2015-12-16 11:36:37 -05:00
stack72 57bcb49ede Change the DB Subnet Group Name to not allow UPPERCASE characters. If
this happens, throw a validation error

Add some ValidationTests for the DBSubnetGroupName ValidateFunc
2015-12-16 17:32:47 +01:00
Clint 54e44328e6 Merge pull request #4254 from hashicorp/b-aws-auth-refactor
provider/aws: WIP Refactor AWS Authentication chain
2015-12-16 10:12:06 -06:00
James Nugent 805c4896bd provider/azurerm: Clean up work for base provider
- Add documentation for resources
- Rename files to match standard patterns
- Add acceptance tests for resource groups
- Add acceptance tests for vnets
- Remove ARM_CREDENTIALS file - as discussed this does not appear to be
  an Azure standard, and there is scope for confusion with the
  azureProfile.json file which the CLI generates. If a standard emerges
  we can reconsider this.
- Validate credentials in the schema
- Remove storage testing artefacts
- Use ARM IDs as Terraform IDs
- Use autorest hooks for logging
2015-12-15 18:31:02 -05:00
Nashwan Azhari 63bc8e9852 provider/azurerm: Tidy up minor issues
This commit cleans up some of the work on the Azure ARM provider
following review by @phinze. Specifically:

- Unnecessary ASM-targeted tests are removed
- Validation is added to the `resource_group` resource
- `dns_servers_names` -> `dns_servers` as per the API documentation
- AZURE_SUBSCRIPTION_ID environment variable is renamed to be
  ARM_SUBSCRIPTION_ID in order to match the other environment variables
2015-12-15 17:26:33 -05:00
Nashwan Azhari c279adfc55 provider/azurerm: Initial commit.
This commit brings some of the work over from #3808, but rearchitects to
use a separate provider for Azure Resource Manager. This is in line with
the decisions made by the Azure Powershell Cmdlets, and is important for
usability since the sets of required fields change between the ASM and
ARM APIs.

Currently `azurerm_resource_group` and `azurerm_virtual_network` are
implemented, more resources will follow.
2015-12-15 17:26:33 -05:00
Lars Wander 889b9fc95d Merge pull request #3763 from sl1pm4t/b-gce-instance-no-exist
Issue #3742 - terraform destroy fails if Google Compute Instance no...
2015-12-15 15:02:36 -05:00
Clint 64482422b5 Merge pull request #4146 from hashicorp/b-aws-ebs-validate
providers/aws: Validate IOPs for EBS Volumes
2015-12-15 11:33:49 -06:00
clint shryock adf417809a add some comments on auth refactoring 2015-12-15 10:49:23 -06:00
clint shryock 5f5459a1fb provider/aws: Refactor AWS Authentication chain
- update auth checking to check metadata header
- refactor tests to not export os env vars
2015-12-15 10:46:10 -06:00
Lars Wander 41cd85c7d8 Merge pull request #3892 from lwander/b-gcp-instance-group-restart
provider/google: Fix instance group manager instance restart policy
2015-12-15 11:38:12 -05:00
clint shryock d7a73937eb provider/aws: Guard against nil DB Parameter vaules 2015-12-14 14:45:27 -06:00
Chris Marchesi bfa4a88170 Retry InvalidParameterValueException errors due to newly created resources 2015-12-14 11:12:06 -08:00
Chris Marchesi 559aa50a31 Retry MalformedPolicy errors due to newly created principals 2015-12-14 10:42:08 -08:00
Spencer Nelson 063d770e51 provider/aws: Kinesis DescribeStream pagination
Each call to the Kinesis DescribeStream API returns a limited number of
shards. When interrogating AWS for the state of a Kinesis stream, the
client needs to page through the API's responses to get the true number
of shards.
2015-12-14 11:27:00 -05:00
justnom 38509d583d Fixes #4253 2015-12-14 10:33:08 -05:00
Martin Atkins 98fc16ec06 Only refresh project name if Rundeck server provides it.
It seems that not all Rundeck servers consistently return the project name
when retrieving a job. Not yet sure in what situations it is or isn't
returned, but since jobs are not allowed to move between projects anyway
it doesn't hurt to just skip refreshing it if the server provides no
value.
2015-12-13 17:38:08 -08:00
Martin Atkins 6aeffdfb2c chef_node resource. 2015-12-13 15:09:17 -08:00
Martin Atkins 2aab842be1 chef_role resource. 2015-12-13 15:09:17 -08:00
Martin Atkins 25b05c0808 chef_environment resource. 2015-12-13 15:09:17 -08:00
Martin Atkins 406aba4a62 chef_data_bag_item resource. 2015-12-13 15:09:17 -08:00
Martin Atkins d583b936b2 chef_data_bag resource. 2015-12-13 15:09:16 -08:00
Martin Atkins 53aa3fb049 Entry point for chef provider. 2015-12-13 15:09:16 -08:00
Martin Atkins e25a0cafa2 Update for breaking change to Azure library.
vmImageClient.ListVirtualMachineImages takes a parameter as of
68d50cb53a73edfeb7f17f5e86cdc8eb359a9528 in Azure/azure-sdk-for-go .

Passing in a parameters object whose members are all empty strings seems
to restore the previous behavior.
2015-12-13 14:59:24 -08:00
Joe Topjian 1ff403347b provider/openstack: Fix set hash for security group test 2015-12-13 03:15:52 +00:00
Joe Topjian 7cbd18a88d provider/openstack: DevStack Deploy Script
This commit includes a script to deploy a standardized devstack environment
for use with development and testing.
2015-12-13 02:58:29 +00:00
Joe Topjian 4716451617 provider/openstack: Convert block_device from TypeSet to TypeList
This change better reflects how block devices are passed to the Nova API
and allows for future enablement of block_device features. It also resolves
an interpolation bug.
2015-12-12 22:18:23 +00:00
stack72 ed8c5cdeea Fixing some gofmt errors that keep appearing on my master branch 2015-12-12 11:00:54 +00:00
James Nugent 19ea14bf8d Merge pull request #4256 from stack72/aws-asg-scheduled-actions
provider/aws: Autoscaling Group Scheduled Actions
2015-12-11 16:54:13 -05:00
stack72 c965d2278e Adding a resource for aws_autoscaling_schedule 2015-12-11 18:43:38 +00:00
Lars Wander a1676f9eb1 provider/google: gofmt 2015-12-11 12:59:13 -05:00
Lars Wander a1a5788ed8 provider/google: provide assigned_nat_ip as well as nat_ip 2015-12-11 12:57:18 -05:00
toshihisa bedd020dee issue #4137
vpc_endpoint bug fix.
2015-12-12 01:15:54 +09:00
Clint 8b21f284b4 Merge pull request #4259 from stack72/aws-db_parameter_group-tags
provider/aws: Adding Tag support for DB Param Groups
2015-12-11 08:58:26 -06:00
Clint 5b2230588a Merge pull request #4260 from stack72/aws-db_security_group-tags
provider/aws: Adding support for Tags to DB SecurityGroup
2015-12-11 08:48:59 -06:00
stack72 dec5a27f19 Adding the ARN as an output of the DB Subnet Group 2015-12-11 12:39:15 +00:00
stack72 474d6080f0 Adding support for Tags to the DB Security Group 2015-12-11 12:28:24 +00:00
stack72 67c1971e63 Adding support to DB Parameter Group for Tags 2015-12-11 12:07:50 +00:00
stack72 d84d6796c4 Initial CRUD work for the Autoscaling Group Scheduled Actions 2015-12-11 10:53:46 +00:00
James Nugent fb4878cf37 Merge pull request #3853 from stack72/f-aws-db-instance-omit-snapshot
provider/aws: add DB Instance skip_final_snapshot
2015-12-10 18:38:11 -05:00
stack72 2b0c7aa4e9 Making the changes to db_instance skip_final_snapshot on the feedback from @catsby 2015-12-10 23:21:36 +00:00
James Nugent 2fecc72fb0 Merge pull request #3809 from stack72/f-aws-elasticache-cache-nodes-reduction
provider/aws: Ability to reduce nodes in an ElastiCache cluster
2015-12-10 15:30:09 -05:00
stack72 6082e3e732 Changing the db_instance to throw an error is a final snapshot is required but yet no identified is given 2015-12-10 19:11:47 +00:00
stack72 5796b13373 Adding skip_final_snapshop bool to th db_instance. This will allow us to specify whether a snapshot is needed directly rather than checking for an empty string 2015-12-10 19:11:47 +00:00
James Nugent a213fe121d Merge pull request #4245 from grisha/esd_fix
Fix a bug whereby AWS elasticsearch domain access_policies will always appear changed
2015-12-10 14:08:38 -05:00
Paul Hinze cfea7c8e2d provider/vsphere: restore vcenter_server as deprecated field
As promised in my comment in #3718, this preserves backwards
compatibility while warning users of the new proper name for the field.
2015-12-10 12:11:51 -06:00
Paul Hinze 231f0cb474 Merge pull request #4035 from rakutentech/fix-ipv6-bug
provider/vsphere: Change ip_address parameter for ipv6 support
2015-12-10 12:02:11 -06:00
Clint eb3840c574 Merge pull request #4242 from hashicorp/b-aws-lc-guard
provider/aws: Fix missing AMI issue with Launch Configurations
2015-12-10 08:55:49 -06:00
Takaaki Furukawa 68ac4bceaf provider/vsphere: Change ip_address parameter to ipv4_address and ipv6_address for ipv6 support 2015-12-10 18:28:24 +09:00
Grisha Trubetskoy 6fbfd99ace Fix a bug whereby AWS elasticsearch domain access_policy will
always appear changed because of a missing normalizeJson().
2015-12-09 23:29:38 -05:00
Martin Atkins b679bb2b31 Merge pull request #4241 from b-ryan/fix/opsworks-ssh-key-write-only
Make the OpsWorks cookbooks SSH key write only
2015-12-09 18:04:58 -08:00
clint shryock e4dba86098 provider/aws: Fix missing AMI issue with Launch Configurations 2015-12-09 16:39:03 -06:00
clint shryock 5c60f7f2c1 provider/aws: Trap Instance error from mismatched SG IDs and Names 2015-12-09 15:59:36 -06:00
Buck Ryan 921944c956 Make the OpsWorks cookbooks SSH key write only
Fixes #3635

This follows the suggestion of @apparentlymart in
https://github.com/hashicorp/terraform/issues/3635#issuecomment-151000068
to fix the issue of OpsWorks stacks always complaining about the custom
cookbooks SSH key needing to be changed.

Functional tests:

* Created a new stack and gave it an SSH key. The key was written to
  OpsWorks properly.
* Ran "plan" again and terraform indicated it needed to change the SSH
  key, which is expected since terraform cannot read what the existing
  SSH is.
* Removed the key from my resource and this time, "plan" did not have
  any changes. The `tfstate` file indicated the SSH key was "" (empty
  string).
* Changed an unrelated property of the stack. Previously this was not
  working for me due to terraform attempting to change the SSH key.
2015-12-09 16:58:05 -05:00
Clint 078280f1ea Merge pull request #4155 from hashicorp/b-aws-db-replica-storage
providers/aws: Update DB Replica to honor storage type
2015-12-09 13:30:23 -06:00
Clint 501a016692 Merge pull request #4127 from hashicorp/aws-vet
Small updates to AWS provider to make go vet happy
2015-12-09 13:30:07 -06:00
clint shryock 6015874273 providers/aws: Update DB Replica to honor storage type
DB Replica can be of a different storage type, but we were skipping that part.
Note that they are created as the default (or as the primary?) initially,
and then modified to be of the correct type
2015-12-09 13:24:10 -06:00
Clint 9cc5e52cf0 Merge pull request #4167 from stack72/aws-security_group_name_prefix
provider/aws: securitygroup name_prefix
2015-12-09 11:42:34 -06:00
Clint 8e20552d44 Merge pull request #4236 from hashicorp/b-aws-s3-hosted-zone-update
providers/aws: Update Hosted Zones to fix issue with eu-central
2015-12-09 10:51:02 -06:00
clint shryock bd22c77c1f providers/aws: Update Hosted Zones to fix issue with eu-central 2015-12-09 10:44:22 -06:00
Paul Hinze 5630f9581f Merge pull request #4196 from kristinn/create-disk-before-startup
provider/vsphere: Create and attach additional disks before bootup.
2015-12-09 10:06:34 -06:00
Paul Hinze e065bec624 Merge pull request #3939 from matt-deboer/master
vsphere-provider: Added folder handling for folder-qualified vm names
2015-12-09 09:55:06 -06:00
Clint ced42342ff Merge pull request #4215 from hashicorp/pr-4207
Fix issue creating AWS RDS replicas across regions
2015-12-09 09:54:53 -06:00
Clint 9044807152 Merge pull request #4221 from hashicorp/b-aws-runinstances-check
provider/aws: Handle empty Instances response from RunInstances
2015-12-09 09:54:02 -06:00
Joe Topjian 3dc45039d1 Merge pull request #4204 from jtopjian/jtopjian-openstack-deleting-volume
provider/openstack: Handle volumes in "deleting" state
2015-12-08 22:58:32 -07:00
Joe Topjian 8ebb74cbff Merge pull request #4223 from nicgrayson/increase-OS-timeout
provider/openstack: increase instance timeout from 10 to 30 minutes
2015-12-08 22:19:05 -07:00
mdeboercw 67bfc2faef Added folder handling for folder-qualified vm names
Added acceptance test for creation in folders

Added 'baseName' as computed schema attribute for convenience

Added 'base_name' computed attribute for convenience

Added new vsphere folder resource

Fixed folder behavior

Assure test folders are properly removed

Avoid creating recreating search index in loop

Fix typeo in vsphere.createFolder

Updated website documentation

Renamed test folders to be unique across tests

Fixes based on acc test findings; code cleanup

Added combined folder and vm acc test

Restored newline; fixed skipped acc tests

Marked 'existing_path' as computed only

Removed debug logging from tests

Changed folder read to return error
2015-12-08 20:35:27 -08:00
Paul Hinze 5884323c99 Merge pull request #4208 from stack72/aws-dynamodb_streams
provider/aws: DynamoDB Table StreamSpecifications
2015-12-08 18:42:48 -06:00
Paul Hinze baeb790ed9 provider/aws: fix capitalization in acctest names 2015-12-08 17:49:17 -06:00
James Nugent 6e45319102 Merge pull request #4216 from stack72/f-do-floatingip_read
provider/digitalocean: FloatingIP Read Func for Region
2015-12-08 17:18:54 -05:00
Nic Grayson ef9838c796 increased openstack 10 minute timeouts to 30 minutes 2015-12-08 16:03:33 -06:00
Clint 9f5f30650f Merge pull request #4168 from combor/malformed_xml_fix
S3 bucket force_destroy error: MalformedXML
2015-12-08 15:24:50 -06:00
stack72 8b79881dea Adding a validation function for the DynamoDb Table StreamViewType 2015-12-08 20:58:06 +00:00
Paul Hinze a6ca034968 provider/aws: run codeclimate tests in us-east-1
It's only available there.
2015-12-08 14:46:08 -06:00
Paul Hinze 6e32320e41 provider/aws: switch test to use more accessible ami
Switch out an AMI that doesn't require marketplace terms acceptance.
2015-12-08 14:40:24 -06:00
clint shryock 9fc6c27de1 provider/aws: Check for empty instances in AWS Instance RunInstance response
Fixes #4206
2015-12-08 14:37:54 -06:00
stack72 22388139a3 Changing the DigitalOcean FloatingIP Read func to check for Droplet Region and then fallback to FloatingIP Region 2015-12-08 17:08:02 +00:00
clint shryock e52af33db7 remove extra DBSubnetGroupName 2015-12-08 10:55:57 -06:00
clint shryock 0619898f6a provider/aws: Add arn to DB Instance output 2015-12-08 10:52:17 -06:00
James Nugent 53609c89c5 Merge pull request #4214 from stack72/f-do-floatingip_panic
provider/digitalocean: Fixing panic condition on FloatingIP droplet
2015-12-08 11:37:59 -05:00
stack72 4b5cb07475 Fixing the digitalocean floatingip resource for a panic when droplet wasn't available 2015-12-08 16:29:13 +00:00
stack72 d46348c233 Adding support for AWS DynamoDB Table for StreamSpecifications 2015-12-08 14:07:11 +00:00
Philipp Preß 1cd2fea1f9 Fix AWS RDS cross-region read replica always being placed in default VPC
Fixes #4192 by honouring the `db_subnet_group_name` parameter when creating a cross-region read replica.
2015-12-08 15:06:57 +01:00
Joe Topjian c3f6bbcece provider/openstack: Handle volumes in "deleting" state
This commit prevents Terraform from erroring when an attempt is made
to delete a volume already in a "deleting" state. This can happen when
the volume is the root disk of an instance and the instance was
terminated.
2015-12-08 06:33:06 +00:00
clint shryock cf87642bc8 provider/aws: Fix issue destroy Route 53 zone/record if it no longer exists 2015-12-07 16:33:37 -06:00
clint shryock d69abbaeda Run go fmt on VMWare vCloud Director provider 2015-12-07 15:24:34 -06:00
Kristinn Örn Sigurðsson aa97300a3b Create and attach additional disks before bootup.
Additional disks weren't created and attached to cloned vms until after bootup.

I also fixed some typos.
2015-12-07 22:16:52 +01:00
clint shryock 7bf404619c adjust the ebs validation to not error, only log, and only set iops for io1 2015-12-07 14:49:44 -06:00
clint shryock 5e54bcc6ff Add test for iops with gp2, remove strict validation 2015-12-07 11:16:29 -06:00
Alex Berghage 53f02fc4a2 Analogous to #3768 -- just for DNS and keys.
The error string for 404s on DNS domains has (apparently)
changed, causing things to be a little sad when you modify
DNS domains from the DO console instead of terraform. This
is just the same fix as was applied to droplets around this
time last month.

While I was at it I just fixed this everywhere I saw it in the
DO provider source tree.
2015-12-06 07:13:14 -05:00
Martin Atkins 283a838b58 Merge #3930: tls_locally_signed_cert resource 2015-12-04 13:30:37 -08:00
Piotr Komborski 3d28b8dec2 S3 bucket force_destroy error: MalformedXML
AWS provider was not checking whether DeleteMarkers are left in S3
bucket causing s3.DeleteObjectsInput to send empty XML which resulted in
400 error and MalformedXML message.
2015-12-04 15:24:23 +00:00
Paul Hinze 30a87be969 Merge pull request #4150 from svanharmelen/f-cloudstack-performance
provider/cloudstack: performance improvements
2015-12-04 09:07:10 -06:00
Takaaki Furukawa 3a08cc9334 provider/vsphere: Add allow_unverified_ssl flag for unverified SSL requests 2015-12-04 08:49:22 -06:00
stack72 6817e0d144 Adding the ability to generate a securitygroup name-prefix 2015-12-04 09:21:08 -05:00
Adrian Chelaru e1eef15646 postgresql provider with "database" and "role" resources 2015-12-03 23:44:20 -08:00
Paul Hinze 8e40b6b855 provider/aws: fixes to ASG placement_group tests
Based on @stack72's recommendations in #3704, thanks @stack72!
2015-12-03 18:17:54 -06:00
Paul Hinze 709d1f3599 Merge pull request #3704 from dayer4b/add-placement-group
added placement group as an option for autoscaling groups
2015-12-03 18:05:01 -06:00
Paul Hinze 9e68c34abe Merge pull request #3785 from hmrc/master
VMWare vCloud Director Support
2015-12-03 15:51:47 -06:00
Clint 79c9953b83 Merge pull request #4075 from elblivion/fix-elb-ec2-classic
provider/aws: Skip SG ID determination logic for Classic ELBs
2015-12-03 14:23:14 -06:00
Sander van Harmelen b8f3417e79 Change all firewall related resources to take a cidr_list
Also some additional tweaks to improve performance and add in a little
concurrency to speed things up a little.
2015-12-03 15:34:53 +01:00
Paul Bellamy 52d178b7ac provider/docker: Inline ports and volumes schemas for consistency 2015-12-03 10:51:59 +00:00
Paul Bellamy 7a24764c15 provider/docker: Add hosts parameter for containers 2015-12-03 10:32:41 +00:00
Joe Topjian 387a8ea127 Merge pull request #3926 from jtopjian/jtopjian-openstack-lbaas-statechange
provider/openstack: Add State Change support to LBaaS Resources
2015-12-02 20:25:04 -07:00
James Nugent 597fafbb68 provider/docker: locate container via ID not name
This reapplies the patch mentioned in #3364 - for an unknown reason the
diff there was incorrect.
2015-12-02 17:27:24 -05:00
clint shryock d1bba3095b providers/aws: Validate IOPs for EBS Volumes 2015-12-02 15:20:11 -06:00
stack72 2882d01904 Work to allow reducing the Number of Cache Nodes in an ElastiCache Cluster 2015-12-02 21:07:50 +00:00
Dave Cunningham d6ae527159 Merge pull request #3671 from 22Acacia/google-pubsub-clean
Google Cloud: PubSub Topic and Subscription resources
2015-12-02 15:37:23 -05:00
James Nugent 4343e60481 Merge pull request #4144 from hashicorp/b-brittle-docker-image-tests
provider/docker: Refer to a tag instead of latest
2015-12-02 15:16:48 -05:00
James Nugent 4ce6455e8a provider/docker: Refer to a tag instead of latest
This should make tests more stable going forward. Also switch out the
image used from Ubuntu to Alpine Linux to reduce required download size
during test runs.
2015-12-02 15:08:16 -05:00
Paul Hinze 4216a8d1e1 Merge pull request #3718 from rakutentech/rename-config-parameters
provider/vsphere: rename vcenter_server config parameter to something clearer
2015-12-02 14:04:52 -06:00
Paul Hinze 6c76984419 Merge pull request #3867 from chrislovecnm/vsphere-custom-vm-params
vSphere custom vm params
2015-12-02 14:00:30 -06:00
pat 6f7ef2fadd golang pubsub SDK has been released. moved topics/subscriptions to use that
Conflicts:
	builtin/providers/google/provider.go
	builtin/providers/google/resource_subscription.go
	builtin/providers/google/resource_subscription_test.go

golang pubsub SDK has been released.  moved topics/subscriptions to use that

Conflicts:
	builtin/providers/google/provider.go
	builtin/providers/google/resource_subscription.go
	builtin/providers/google/resource_subscription_test.go

file renames and add documentation files

remove typo'd merge and type file move

add to index page as well

only need to define that once

remove topic_computed schema value

I think this was used at one point but is no longer. away.

cleanup typo

adds a couple more config values

- ackDeadlineSeconds: number of seconds to wait for an ack
- pushAttributes: attributes of a push subscription
- pushEndpoint: target for a push subscription

rearrange to better match current conventions

respond to all of the comments
2015-12-02 10:36:00 -08:00
James Nugent 50d7abcd8a Merge pull request #3761 from ryane/f-provider-docker-improvements
provider/docker: support additional arguments for `docker_container` resource
2015-12-02 11:46:29 -05:00
James Nugent 69272f3113 provider/aws: error with empty list item on sg
This addresses the case where `compact` has not been used on a list
passed into security group as cidr_block. See #3786. Compact is still
the correct answer there, but we should prefer returning an error to
a panic. Fixes #3786.
2015-12-02 11:36:50 -05:00
clint shryock be07e4c0c9 cleanup spot instance attribute setting 2015-12-01 15:25:53 -06:00
clint shryock c5f0c8ced6 provider/aws: Check for nil on some spot instance attributes 2015-12-01 14:58:59 -06:00
clint shryock 4a5847f9ea providers/aws: Vet aws 2015-12-01 10:00:35 -06:00
James Nugent 9987f36d86 Merge pull request #4093 from paybyphone/master
provider/aws: New resource `aws_lambda_event_source_mapping`
2015-12-01 08:36:45 -05:00
Sander van Harmelen 84645bd8b5 More tweaks to improve performance 2015-12-01 00:36:33 +01:00
Chris Marchesi 85627630bd New resource (AWS provider) - aws_lambda_event_source_mapping 2015-11-30 07:45:38 -08:00
James Nugent 85c8595c89 Merge pull request #4108 from stack72/f-aws-route53-spf-record
provider/aws: Normalization of SPF records to prevent reporting changes
2015-11-30 13:15:32 +00:00
stack72 fece57f83b Changing the IAM Role resource to allow update of Assume Policy Document 2015-11-30 12:52:07 +00:00
stack72 a556c98cde Adding support for the escapaing of Route53 SPF records 2015-11-30 12:14:39 +00:00
stack72 ee4d29ce97 Added some acceptance tests for the statuscake provider 2015-11-27 15:03:13 +00:00
stack72 038604d97d Migrating the statuscake_test resource to use the new version of the statuscake client 2015-11-27 15:03:13 +00:00
stack72 34b77aa78b Adding the update and read functionality for the statuscake client 2015-11-27 15:03:13 +00:00
stack72 97c0aa5e73 Using the latest version of the statuscake client 2015-11-27 15:03:13 +00:00
stack72 d26f5f93e4 Created the initial scaffolding for the statuscake provider 2015-11-27 15:03:13 +00:00
Sander van Harmelen d4ce2b87fb Modified executable bit 2015-11-27 14:49:28 +01:00
stack72 0cca74fe76 Changing the S3 Bucket resource to allow the update of ACL by using PutBucketAcl 2015-11-26 21:45:48 +00:00
Anthony Stanton 5753efa8af Skip SG ID determination logic for Classic ELBs 2015-11-26 15:34:28 +01:00
stack72 632a9147cc Adding support for Block_Durations to AWS Spot instance 2015-11-26 11:56:04 +00:00
James Nugent b7a12e3a58 Merge pull request #4009 from apparentlymart/aws-opsworks-acctest-iam
provider/aws: AWS Opsworks tests bring their own IAM objects
2015-11-25 21:26:40 +02:00
James Nugent c262bc72ea Merge pull request #3895 from br0ch0n/rds_pub_access_param
Issue #3894 RDS publicly_accessible param shouldn't force new resource
2015-11-25 21:09:23 +02:00
Brett Mack aec94b1682 Don't error if unable to undeploy 2015-11-25 16:53:00 +00:00
James Nugent ca2a7ee120 Merge pull request #4051 from svanharmelen/f-reduce-api-calls
provider/cloudstack: improve performance for all firewall related resources
2015-11-25 14:06:42 +02:00
Brett Mack a02667389e Only undeploy a machine if it is switched on 2015-11-25 12:05:59 +00:00
chrislovecnm 811a82d9b3 updating printf formating to correct syntax with int 2015-11-25 07:59:46 +00:00
chrislovecnm de2c76a61c polish 2015-11-25 00:48:44 -07:00
chrislovecnm d70cdde233 merging in upstream, because rebase was insane 2015-11-25 00:44:27 -07:00
Chris Love 1d1de992af adding better acceptance test to check custom config 2015-11-25 05:41:01 +00:00
Chris Love a35b65e5d2 working on better test 2015-11-24 21:35:40 -07:00
clint shryock e9cb722471 providers/aws: Fix issue recreating security group rule if it has been destroyed 2015-11-24 13:50:30 -06:00
Sander van Harmelen a3eae45b32 Improve performance all firewall related resources 2015-11-24 18:27:52 +01:00
Paul Hinze 5e0b603212 Merge pull request #4041 from svanharmelen/b-chef-provisioner
Revert changing `path.Join()` to `filepath.Join()` (PR #3896)
2015-11-24 08:44:46 -06:00
Sander van Harmelen b007d4f77a Revert changing `path.Join()` to `filepath.Join()` (PR #3896)
PR #3896 added support for passing keys by content, but in this same PR
all references to `path.Join()` where changed to `filepath.join()`.
There is however a significant difference between these two calls and
using the latter one now causes issues when running the Chef
provisioner on Windows (see issue #4039).
2015-11-24 14:40:46 +01:00
James Nugent 1cde2e64a0 Merge pull request #3748 from stack72/do-floatingips
provider/digitalocean : New Resource for Floating IPs
2015-11-24 13:16:24 +02:00
stack72 3fc9107333 Using the laterst version of the DO API to get the Assign of an IP working without a time.Sleep 2015-11-24 11:08:43 +00:00
James Nugent 288e568272 Merge pull request #4024 from rjeczalik/nil-deref-fix
provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452
2015-11-24 11:52:33 +02:00
Rafal Jeczalik 9e66e18334 provider/aws: fix for https://github.com/aws/aws-sdk-go/issues/452 2015-11-24 09:30:21 +01:00
James Nugent 99e3d62cd8 provider/aws: Make VPC ID required on subnets 2015-11-23 16:53:49 +02:00
Clint 82050ff832 Merge pull request #4005 from hashicorp/b-aws-iam-user-delete
provider/aws: Fix issue deleting users who are attached to a group
2015-11-23 08:22:48 -06:00
Clint 7772a66b2f Merge pull request #3940 from hashicorp/b-aws-spot-instance-updates
providers/aws: Update Spot Instance request to provide connection information
2015-11-23 08:22:07 -06:00
stack72 150e997a96 Changing the AWS ElastiCache cluster maintenance_window to enforce lowercase 2015-11-23 12:54:56 +00:00
Nicki Watt 3809315af9 Upped default maxRetryTimeout from 30s -> 60s 2015-11-23 11:45:16 +00:00
Radek Simko 749fcd4931 Merge pull request #4010 from pforman/cloudtrail-enable
provider/aws:  Add "enable_logging" to CloudTrail resource
2015-11-23 07:59:29 +00:00
Paul Forman 52aad04930 Mistake in type refactor in cloudTrailGetLoggingStatus
When adjusting the types to prevent casting, I didn't change the error
message to handle the pointer change.  "go tool vet" caught this.
2015-11-22 13:23:08 -07:00
Paul Forman 9cec40ea3c Add missing error-checks from code review
Some error-checking was omitted.

Specifically, the cloudTrailSetLogging call in the Create function was
ignoring the return and cloudTrailGetLoggingStatus could crash on a
nil-dereference during the return.  Fixed both.

Fixed some needless casting in cloudTrailGetLoggingStatus.
Clarified error message in acceptance tests.
Removed needless option from example in docs.
2015-11-22 12:54:11 -07:00
Paul Forman 484887c0c5 Change default for logging in CloudTrail to true
The default for `enable_logging`, which defines whether CloudTrail
actually logs events was originally written as defaulting to `false`,
since that's how AWS creates trails.

`true` is likely a better default for Terraform users.

Changed the default and updated the docs.
Changed the acceptance tests to verify new default behavior.
2015-11-22 10:47:23 -07:00
James Nugent 774ed1ded8 Merge pull request #4012 from rakutentech/rename-function
provider/vsphere: Rename create* functions
2015-11-22 11:34:42 +02:00
Paul Forman c9eeb161e0 Add a comment in tests
The purpose of the first test of enable_logging wasn't quite clear.

It's future-proofing against the assumptions made about AWS behavior.
2015-11-21 14:55:08 -07:00
Martin Atkins 11190144f0 AWS Opsworks tests bring their own IAM objects.
Previously we assumed the existence of some default objects that most
Opsworks users have because the Opsworks console creates them by default
when a new stack is created.

However, that meant that these tests wouldn't work correctly for anyone
who either had never used Opsworks via the UI or who had never accepted
the default of having the console create some predefined IAM objects to
use. It may also have led to some weird failures if a particular user had
customized the settings for these default objects.

Now the tests create suitable IAM roles, a policy and an instance profile
and use these when creating Opsworks stacks, avoiding any dependency
on any pre-existing objects.

This fixes #3998.
2015-11-21 11:13:25 -08:00
Nicki Watt f1c2be9772 Make maxRetryTimeout (in seconds) configurable 2015-11-21 12:54:59 +00:00
Paul Forman f98dbbb580 Tests and docs for AWS CloudTrail "enable_logging"
Add acceptance tests for creation, enable, and disable logging.

Add option to docs and example.
2015-11-21 00:18:38 -07:00
Paul Forman 52db098292 Add enable_logging to AWS CloudTrail
The AWS CloudTrail resource is capable of creating CloudTrail resources,
but AWS defaults the actual logging of the trails to `false`, and
Terraform has no method to enable or monitor the status of logging.

CloudTrail trails that are inactive aren't very useful, and it's a
surprise to discover they aren't logging on creation.

Added an `enable_logging` parameter to resource_aws_cloudtrail to enable
logging.  This requires some extra API calls, which are wrapped in new
internal functions.

For compatibility with AWS, the default of `enable_logging` is set to
`false`.
2015-11-21 00:18:38 -07:00
clint shryock 233aab6e0a provider/aws: Fix issue deleting users who are attached to a group
If you want to delete an IAM user, that user must not belong to any groups
2015-11-20 16:54:26 -06:00
Clint cc70d25dc5 Merge pull request #3898 from hashicorp/b-aws-elb-iam-cert-delete
providers/aws: Retry deleting IAM Server Cert on dependency violation
2015-11-20 14:50:18 -06:00
Clint 9edbf6a7fc Merge pull request #3908 from hashicorp/b-elb-cookie-fix
provider/aws: Fix issue with LB Cookie Stickiness and empty expiration period
2015-11-20 14:49:00 -06:00
Clint ed3399593a Merge pull request #3996 from hashicorp/b-aws-test-fixes
Adjustments for AWS Acceptance tests
2015-11-20 13:28:25 -06:00
clint shryock 9eb46c28b2 use a log group resourcE 2015-11-20 13:15:20 -06:00
clint shryock cf5b32617b fix vpn gateway refresh/reattach issue 2015-11-20 11:47:10 -06:00
stack72 74c93d3a46 Reording the code for the creation of a Floating IP for a droplet. The call to the DO api takes a few seconds to propagate so I had to sacriface some kittens and added a short 10 second sleep 2015-11-20 19:12:31 +02:00
stack72 7bda855590 Adding the work to assign a Floating IP to a Droplet 2015-11-20 19:12:31 +02:00
stack72 9cf1c2943c Adding the first pass of the work to get a floatingip assigned to a region 2015-11-20 19:12:30 +02:00
Paul Hinze 24d15820c1 provider/heroku: fix acc test
depends_on requires a list of strings. the old parser would silently
ignore this field, but the new one returned a syntax error.
2015-11-20 10:51:34 -06:00
Paul Hinze c637ca039c Merge pull request #3987 from hashicorp/b-aws-test-fixes
AWS Test fixtures updates
2015-11-20 10:36:38 -06:00
Paul Hinze 2f25d57e7c Merge pull request #3993 from lwander/b-gcp-test-ssl-cert
provider/google: self-signed ssl certs for testing
2015-11-20 10:36:27 -06:00
Lars Wander 93ff7edb13 provider/google: self-signed ssl certs for testing 2015-11-20 11:32:25 -05:00
Paul Hinze e67551a641 provider/docker: fix image test
there's a new latest in town
2015-11-20 09:58:03 -06:00
Paul Hinze e9a18a8f9f provider/google: fix sql database test
Was missing a required parameter

/cc @lwander @sparkprime
2015-11-20 09:52:23 -06:00
Julien Fabre ed3f54cc47 Add AWS Classiclink for AWS VPC resource 2015-11-20 16:48:48 +01:00
clint shryock 73475edceb update TestAccAWSFlowLog_subnet to use new cloudwatch resource, not needing env var anymore 2015-11-20 09:39:43 -06:00