5160578e18
helper/resource: restore retval of resource.Retry on timeout
...
In #4700 while fixing a data race I made an incorrect assumption about
the return value of StateChangeConf, and ended up changing the behavior
in the timeout case to always return:
> timeout while waiting for state to become '[success]'
When it used to capture the "most recent error" from the function
itself.
It's much more useful to see that error bubbling up, so here we revert
to pulling it out of the function as we did before, and we protect
against the data race with a good old fashioned mutex.
2016-03-04 11:20:48 -06:00
f11448c692
Update CHANGELOG.md
2016-03-03 21:36:42 -07:00
a786d3d4ae
Merge pull request #5432 from jtopjian/openstack-instance-tenantnet-403
...
provider/openstack: Account for a 403 reply from os-tenant-networks
2016-03-03 21:35:40 -07:00
76f203e7e4
build: Update make core-test for vendoring
2016-03-03 18:08:31 -06:00
8d31c93862
Merge pull request #5439 from evandbrown/pubsub
...
provider/google: Fix Pubsub acceptance tests
2016-03-02 18:37:31 -06:00
2e958f7a12
provider/google: Fix Pubsub acceptance tests
...
Acceptance tests for Pubsub topics and subscriptions failed after
incorrectly determining that resources were not deleted in the
CheckDestroy phase.
Fixes 5437
2016-03-02 15:36:32 -08:00
57bd4dcd4f
Merge pull request #5433 from evandbrown/vpntest
...
provider/google: Fix VPN tunnel creation test
2016-03-02 16:00:54 -06:00
65d96ef58a
provider/openstack: Account for a 403 reply from os-tenant-networks
2016-03-02 21:17:59 +00:00
87006d6a0c
provider/google: Fix VPN tunnel creation test
...
The GCE API for creating VPN tunnels began validating the `peerIp` field
and rejecting RFC5735 addresses. The previous test was using one of
these addresses and failing as a result. This commit uses 8.8.8.8
for the peerIp.
2016-03-02 13:17:38 -08:00
834bfcdc7a
providder/azure: ASM image names have dates in them :-|
2016-03-02 13:02:48 -06:00
a7a9b14c59
Merge pull request #5405 from gamename/master
...
Updates to docs per request on mailer
2016-03-01 17:28:42 -06:00
3bc09db7e0
docs(variables): redundant wording
2016-03-01 17:13:05 -06:00
c6b350b98e
docs(variables): describe order of evaluation with files
2016-03-01 17:08:57 -06:00
986eefcfe2
Merge pull request #5391 from jtopjian/openstack-secgroup-icmp-zero
...
provider/openstack: Allow ICMP Security Groups with values of zero
2016-03-01 12:48:12 -07:00
a9d5903dbe
Update CHANGELOG.md
2016-03-01 12:52:02 -06:00
3ee2e942d0
Merge pull request #5400 from hashicorp/phinze/update-hcl
...
deps: update hcl to latest
2016-03-01 12:50:05 -06:00
361c1a0992
README.md - expand dependency docs a bit
2016-03-01 12:49:17 -06:00
ae8627f92a
Report the correct number of shards
2016-03-01 10:46:39 -08:00
de97bad050
deps: update hcl to latest
...
refs #5372
2016-03-01 12:39:40 -06:00
c9e3b7f51d
Update CHANGELOG.md
2016-03-01 09:29:49 -08:00
c1ce8ff31a
Merge pull request #5218 from paybyphone/paybyphone_set_maxitems
...
Add MaxItems attribute to Schema
2016-03-01 09:27:59 -08:00
6016904f2e
Update CHANGELOG.md
2016-03-01 14:11:23 +00:00
528bad36ff
Merge pull request #5395 from TimeIncOSS/b-cw-even-target-role
...
provider/aws: Allow recovering from failed CloudWatch Event Target creation
2016-03-01 14:10:10 +00:00
8ca732528c
docs: CloudWatch Event Target expects role name (not ARN)
2016-03-01 12:38:55 +00:00
dc45f84a8f
Allow recovering from failed CW Event Target creation in state
2016-03-01 12:37:36 +00:00
5a786d52d9
Fix: Do not store ID of CW Event Target if creation fails
2016-03-01 12:35:15 +00:00
b0b4341b5e
vendor: Update dependency gophercloud to latest
2016-03-01 03:30:42 +00:00
9332a1ddac
provider/openstack: Add test for ICMP SecGroup rules with type zero
...
This is to just catch possible breakage in the future. The actual
support was done in Gophercloud.
Previously, values of 0 were not allowed since there's no such port
as 0. However, there are ICMP codes of 0.
2016-03-01 03:29:14 +00:00
1448b84b37
Update CHANGELOG.md
2016-02-29 21:42:22 +00:00
ba5cdfea55
Merge pull request #4688 from stack72/aws-asg-metrics
...
provider/aws: Autoscaling Metrics Collection resource
2016-02-29 21:41:07 +00:00
d3697fa50b
provider/aws: Combine AWS Metrics Collection resource and AWS
...
Autoscaling Group
2016-02-29 20:58:41 +00:00
8bdd92187c
Merge pull request #4446 from TimeIncOSS/f-schema-new-resource
...
helper/schema: Allow identification of a new resource in update func
2016-02-29 20:07:00 +00:00
4fc1391303
Scaffold the AWS Autoscaling Group Metrics Collection
2016-02-29 19:24:30 +00:00
b991541cce
Merge pull request #5378 from hashicorp/phinze/acctest-readme
...
README: link off to CONTRIBUTING for acctest info
2016-02-29 13:16:11 -06:00
cbd02dd3ef
README: link off to CONTRIBUTING for acctest info
...
Acctest info in README was a bit stale since the enhanced contributing
guide landed.
2016-02-29 12:49:41 -06:00
c47af4cb00
Merge pull request #5375 from hashicorp/phinze/doc-aws-sg-forcenew
...
provider/aws docs: Mark ForceNew fields, note about description
2016-02-29 12:38:39 -06:00
c5709ce913
Merge pull request #5084 from hashicorp/phinze/acctest-nonemptyplan-log
...
acctests: log a line w/ the non-empty plan
2016-02-29 12:35:14 -06:00
0d728bee70
provider/aws docs: Mark ForceNew fields, note about description
...
The `description` field is easy to confuse for a nice field to
add an arbitrary comment to - and it's surprising that changes to this
field force a new resource, so we add a big note about it to point users
at tags.
Also marked all the other ForceNew attributes on this resource.
2016-02-29 12:06:33 -06:00
bba8a79a52
acctests: log a line w/ the non-empty plan
...
Helpful when iterating on a drift test.
Eventually I think this assertion could be fanned out to something much
more targeted like:
ExpectAttributeDiff(resource, attr, oldval, newval)
But this is a step in the right direction.
2016-02-29 11:50:42 -06:00
00bbf4a731
Update CHANGELOG.md
2016-02-29 17:39:11 +00:00
e6f3fafcd6
Merge pull request #5361 from stack72/b-aws-es-tags
...
provider/aws: `aws_elastisearch_domain` tags not being set correctly.
2016-02-29 17:38:06 +00:00
304fc424cd
Update CHANGELOG.md
2016-02-29 08:45:12 -07:00
b72cb19606
Merge pull request #5366 from jtopjian/openstack-readd-server-access
...
provider/openstack: Re-Add server.AccessIPv4 and server.AccessIPv6
2016-02-29 08:44:16 -07:00
0ddf8f4dbd
Update CHANGELOG.md
2016-02-29 14:51:21 +00:00
5aafacc4db
Merge pull request #5370 from TimeIncOSS/mb-lambda-s3-object-version-not-required
...
Lambda S3 object version defaults to '$LATEST' if unspecified
2016-02-29 14:49:35 +00:00
0290884fdc
Lambda S3 object version defaults to '$LATEST' if unspecified
2016-02-29 14:31:47 +00:00
7d6116d7c2
provider/openstack: Re-Add server.AccessIPv4 and server.AccessIPv6
...
GH-4812 removed reading server.AccessIPv4 and server.AccessIPv6
because, AFAICT, they are not set by Nova. After removal, a user
reported that they were no longer able to read IPs from access_ip_v4
and access_ip_v6 on Rackspace. It's possible that Rackspace sets
the AccessIPv* attributes, and if that's true, other cloud providers
might as well through custom extensions.
The priority of how access_ip_v* is set might require some tweaks in
the future.
2016-02-28 21:39:45 +00:00
6c2715dabe
Update CHANGELOG.md
2016-02-28 12:15:55 -07:00
ba8033bf74
Merge pull request #5365 from jtopjian/openstack-instance-network-update-guard
...
provider/openstack: Safely typecast network during instance update
2016-02-28 12:13:44 -07:00
d82a4c9259
provider/openstack: Safely typecast network during instance update
...
This commit protects against unsafe typecasting when an instance is
updating its network configuration.
2016-02-28 19:02:53 +00:00
Paul Hinze