Commit Graph

6 Commits

Author SHA1 Message Date
Mitchell Hashimoto 79dbd07679 providers/aws: no empty security groups when flattening ip perms
/cc @pearkes - A few things here:

First, this fixes the issue you mentioned to be in chat. Basically: if
there are no security groups, don't put it into flatten, because flatten
will include a "key.#" = "0".

Next, I transformed your test into a "table-driven" test which are really
nice to write and maintain. Basically, as you find bugs or edge cases, you can
just add to the table and you get the test for free. I recommend these
whereever you have a pure input to output sort of data transformation
function.
2014-07-16 18:32:36 -07:00
Jack Pearkes bcc6f884b1 providers/aws: actually return ingress rule on refresh, tests 2014-07-16 20:14:01 -04:00
Jack Pearkes 901785d04a providers/aws: expand wildcard string lists 2014-07-16 18:51:50 -04:00
Jack Pearkes 47468c32a4 providers/aws: egress and ingress for sg 2014-07-08 16:34:10 -04:00
Jack Pearkes 0f64ff9387 providers/aws: availability_zones and expandList 2014-07-07 10:07:06 -04:00
Jack Pearkes 1b6faa0eb9 providers/aws: helper for expanding listeners 2014-07-07 10:07:06 -04:00