terraform/states/statefile
Martin Atkins 8b511524d6
Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978)
* Introduce "Local" terminology for non-absolute provider config addresses

In a future change AbsProviderConfig and LocalProviderConfig are going to
become two entirely distinct types, rather than Abs embedding Local as
written here. This naming change is in preparation for that subsequent
work, which will also include introducing a new "ProviderConfig" type
that is an interface that AbsProviderConfig and LocalProviderConfig both
implement.

This is intended to be largely just a naming change to get started, so
we can deal with all of the messy renaming. However, this did also require
a slight change in modeling where the Resource.DefaultProviderConfig
method has become Resource.DefaultProvider returning a Provider address
directly, because this method doesn't have enough information to construct
a true and accurate LocalProviderConfig -- it would need to refer to the
configuration to know what this module is calling the provider it has
selected.

In order to leave a trail to follow for subsequent work, all of the
changes here are intended to ensure that remaining work will become
obvious via compile-time errors when all of the following changes happen:
- The concept of "legacy" provider addresses is removed from the addrs
  package, including removing addrs.NewLegacyProvider and
  addrs.Provider.LegacyString.
- addrs.AbsProviderConfig stops having addrs.LocalProviderConfig embedded
  in it and has an addrs.Provider and a string alias directly instead.
- The provider-schema-handling parts of Terraform core are updated to
  work with addrs.Provider to identify providers, rather than legacy
  strings.

In particular, there are still several codepaths here making legacy
provider address assumptions (in order to limit the scope of this change)
but I've made sure each one is doing something that relies on at least
one of the above changes not having been made yet.

* addrs: ProviderConfig interface

In a (very) few special situations in the main "terraform" package we need
to make runtime decisions about whether a provider config is absolute
or local.

We currently do that by exploiting the fact that AbsProviderConfig has
LocalProviderConfig nested inside of it and so in the local case we can
just ignore the wrapping AbsProviderConfig and use the embedded value.

In a future change we'll be moving away from that embedding and making
these two types distinct in order to represent that mapping between them
requires consulting a lookup table in the configuration, and so here we
introduce a new interface type ProviderConfig that can represent either
AbsProviderConfig or LocalProviderConfig decided dynamically at runtime.

This also includes the Config.ResolveAbsProviderAddr method that will
eventually be responsible for that local-to-absolute translation, so
that callers with access to the configuration can normalize to an
addrs.AbsProviderConfig given a non-nil addrs.ProviderConfig. That's
currently unused because existing callers are still relying on the
simplistic structural transform, but we'll switch them over in a later
commit.

* rename LocalType to LocalName

Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-01-31 08:23:07 -05:00
..
testdata/roundtrip states/statefile: tolerate and ignore invalid depends_on in version 3 2019-11-21 09:18:49 -08:00
diagnostics.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
doc.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
file.go states/statefile: Tolerate nil state in statefile.New 2018-10-16 19:14:11 -07:00
marshal_equal.go command: Allow tests to run to completion without panics or hangs 2018-10-16 19:14:11 -07:00
read.go command: Fix TestInit_getProvider 2018-11-12 15:19:55 -08:00
roundtrip_test.go read+write the new dependencies in the statefile 2019-11-07 17:49:03 -05:00
version0.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
version1.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
version1_upgrade.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
version2.go states/statefile: decode backend hash as uint64 2019-05-28 23:59:36 +09:00
version2_upgrade.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
version3.go statefile: New package for loading and saving state files 2018-10-16 18:49:20 -07:00
version3_upgrade.go Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978) 2020-01-31 08:23:07 -05:00
version4.go read+write the new dependencies in the statefile 2019-11-07 17:49:03 -05:00
write.go always write the current state terraform_version 2019-05-21 18:55:53 -04:00