terraform/states/statemgr
Martin Atkins 8b511524d6
Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978)
* Introduce "Local" terminology for non-absolute provider config addresses

In a future change AbsProviderConfig and LocalProviderConfig are going to
become two entirely distinct types, rather than Abs embedding Local as
written here. This naming change is in preparation for that subsequent
work, which will also include introducing a new "ProviderConfig" type
that is an interface that AbsProviderConfig and LocalProviderConfig both
implement.

This is intended to be largely just a naming change to get started, so
we can deal with all of the messy renaming. However, this did also require
a slight change in modeling where the Resource.DefaultProviderConfig
method has become Resource.DefaultProvider returning a Provider address
directly, because this method doesn't have enough information to construct
a true and accurate LocalProviderConfig -- it would need to refer to the
configuration to know what this module is calling the provider it has
selected.

In order to leave a trail to follow for subsequent work, all of the
changes here are intended to ensure that remaining work will become
obvious via compile-time errors when all of the following changes happen:
- The concept of "legacy" provider addresses is removed from the addrs
  package, including removing addrs.NewLegacyProvider and
  addrs.Provider.LegacyString.
- addrs.AbsProviderConfig stops having addrs.LocalProviderConfig embedded
  in it and has an addrs.Provider and a string alias directly instead.
- The provider-schema-handling parts of Terraform core are updated to
  work with addrs.Provider to identify providers, rather than legacy
  strings.

In particular, there are still several codepaths here making legacy
provider address assumptions (in order to limit the scope of this change)
but I've made sure each one is doing something that relies on at least
one of the above changes not having been made yet.

* addrs: ProviderConfig interface

In a (very) few special situations in the main "terraform" package we need
to make runtime decisions about whether a provider config is absolute
or local.

We currently do that by exploiting the fact that AbsProviderConfig has
LocalProviderConfig nested inside of it and so in the local case we can
just ignore the wrapping AbsProviderConfig and use the embedded value.

In a future change we'll be moving away from that embedding and making
these two types distinct in order to represent that mapping between them
requires consulting a lookup table in the configuration, and so here we
introduce a new interface type ProviderConfig that can represent either
AbsProviderConfig or LocalProviderConfig decided dynamically at runtime.

This also includes the Config.ResolveAbsProviderAddr method that will
eventually be responsible for that local-to-absolute translation, so
that callers with access to the configuration can normalize to an
addrs.AbsProviderConfig given a non-nil addrs.ProviderConfig. That's
currently unused because existing callers are still relying on the
simplistic structural transform, but we'll switch them over in a later
commit.

* rename LocalType to LocalName

Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>
2020-01-31 08:23:07 -05:00
..
testdata statemgr: New package for state managers 2018-10-16 18:49:20 -07:00
doc.go Update doc.go, fix typo (#20529) 2019-03-01 08:59:01 -08:00
filesystem.go states/statemgr: Properly return error when Unlock detects invalid lock id 2019-11-11 15:24:53 -08:00
filesystem_lock_unix.go states/statemgr: Local locks meta is near output path, not input path 2018-11-19 09:02:35 -08:00
filesystem_lock_windows.go states/statemgr: Local locks meta is near output path, not input path 2018-11-19 09:02:35 -08:00
filesystem_test.go states/statemgr: use -mod=vendor to run the state locking helper 2018-12-06 16:50:06 -08:00
helper.go command: Use statemgr.Import and statemgr.Export for state push and pull 2018-11-19 09:02:35 -08:00
lineage.go command/state: update and fix the state push and pull 2018-10-19 19:12:23 +02:00
locker.go states/statemgr: Avoid HTML escaping when printing LockInfo 2019-01-15 10:57:31 +00:00
migrate.go Version tools per Go convention under tools.go 2019-10-17 22:23:39 +02:00
migrate_test.go states/statemgr: Migrate, Import, and Export functions 2018-11-19 09:02:35 -08:00
persistent.go statemgr: New package for state managers 2018-10-16 18:49:20 -07:00
plan.go terraform: Ugly huge change to weave in new State and Plan types 2018-10-16 19:11:09 -07:00
snapshotmetarel_string.go stringer: Regenerate files with latest version 2019-05-13 15:34:27 +01:00
statemgr.go statemgr: Helper funcs RefreshAndRead and WriteAndPersist 2018-10-16 18:58:49 -07:00
statemgr_fake.go statemgr: New package for state managers 2018-10-16 18:49:20 -07:00
statemgr_test.go statemgr: New package for state managers 2018-10-16 18:49:20 -07:00
testing.go Initial steps towards AbsProviderConfig/LocalProviderConfig separation (#23978) 2020-01-31 08:23:07 -05:00
transient.go statemgr: New package for state managers 2018-10-16 18:49:20 -07:00
transient_inmem.go statemgr: New package for state managers 2018-10-16 18:49:20 -07:00