Go to file
Paul Hinze 4a1b36ac0d
core: rerun resource validation before plan and apply
In #7170 we found two scenarios where the type checking done during the
`context.Validate()` graph walk was circumvented, and the subsequent
assumption of type safety in the provider's `Diff()` implementation
caused panics.

Both scenarios have to do with interpolations that reference Computed
values. The sentinel we use to indicate that a value is Computed does
not carry any type information with it yet.

That means that an incorrect reference to a list or a map in a string
attribute can "sneak through" validation only to crop up...

 1. ...during Plan for Data Source References
 2. ...during Apply for Resource references

In order to address this, we:

 * add high-level tests for each of these two scenarios in `provider/test`
 * add context-level tests for the same two scenarios in `terraform`
   (these tests proved _really_ tricky to write!)
 * place an `EvalValidateResource` just before `EvalDiff` and `EvalApply` to
   catch these errors
 * add some plumbing to `Plan()` and `Apply()` to return validation
   errors, which were previously only generated during `Validate()`
 * wrap unit-tests around `EvalValidateResource`
 * add an `IgnoreWarnings` option to `EvalValidateResource` to prevent
   active warnings from halting execution on the second-pass validation

Eventually, we might be able to attach type information to Computed
values, which would allow for these errors to be caught earlier. For
now, this solution keeps us safe from panics and raises the proper
errors to the user.

Fixes #7170
2016-07-01 13:12:57 -05:00
.github Correct grammar in ISSUE_TEMPLATE.md (#6241) 2016-04-19 13:31:54 -05:00
builtin core: rerun resource validation before plan and apply 2016-07-01 13:12:57 -05:00
command Fix plan output for data sources 2016-06-30 15:34:43 -04:00
communicator communicator/ssh: correct test typo 2016-06-29 10:59:55 -05:00
config Add test to ensure key/values interp order 2016-06-29 15:06:59 -04:00
contrib command: Change module-depth default to -1 2016-01-20 13:58:02 -06:00
dag core: Print node types in traces 2016-04-13 10:20:18 -07:00
deps snapshot from CenturyLinkLabs/terraform-provider-clc 2016-03-21 08:58:37 -07:00
digraph Fix TestWriteDot random order error 2014-07-29 10:26:50 -07:00
dot core: graph command gets -verbose and -draw-cycles 2015-04-27 09:23:47 -05:00
examples Fix Google Cloud Two-Tier Example (#7009) 2016-06-05 00:48:54 +01:00
flatmap flatmap: never auto-convert ints 2014-07-24 11:41:01 -07:00
helper core: rerun resource validation before plan and apply 2016-07-01 13:12:57 -05:00
plugin core: New ResourceProvider methods for data resources 2016-05-14 08:26:36 -07:00
scripts make linux amd64 binaries static again. 2016-06-10 16:23:11 +03:00
state provider/azurerm: Bump azure-sdk-for-go to 3.0.0-beta (#7420) 2016-06-30 15:36:08 +01:00
terraform core: rerun resource validation before plan and apply 2016-07-01 13:12:57 -05:00
test-fixtures Remove all traces of libucl 2014-08-19 09:57:04 -07:00
vendor provider/azurerm: `azurerm_dns_zone` now returns `name_servers` (#7434) 2016-07-01 10:26:01 +01:00
website provider/atlas: Add a Atlas Artifact Data Source (#7419) 2016-07-01 10:29:53 -05:00
.gitignore Do not build supporting JS files 2016-03-22 23:33:40 +02:00
.travis.yml travis: switch to unencrypted cookie 2016-03-21 13:35:53 -05:00
BUILDING.md Makefile/docs: Lock in 1.6 req, doc vendored deps 2016-02-24 16:13:49 -06:00
CHANGELOG.md Update CHANGELOG.md 2016-07-01 10:32:39 -05:00
LICENSE Adding license 2014-07-28 13:54:06 -04:00
Makefile build: Allow TESTARGS on make core-test 2016-06-22 16:32:43 +03:00
README.md fix readme numbered indentation (#7277) 2016-06-22 23:37:44 +01:00
Vagrantfile Build with Go 1.6 2016-02-23 12:58:38 -06:00
checkpoint.go fixing version numbers RCs should be labeled x.x.x-rcx 2015-02-07 16:56:56 +01:00
commands.go cli: Fix registration of `state mv`. 2016-06-22 11:46:38 +03:00
config.go Added TF_PLUGIN_DEV to silence internal plugin warnings 2016-05-27 11:49:09 -07:00
config_test.go Update config test to handle provisioners 2014-07-10 11:38:57 -07:00
config_unix.go core: use !windows instead of a list of unixes 2015-12-30 17:37:24 -05:00
config_windows.go config looks in a plugin directory if it exists 2014-09-27 12:36:13 -07:00
help.go Implemented internal plugin calls; which allows us to compile plugins into the main terraform binary 2016-05-10 14:40:11 -04:00
main.go Warn when an internal plugin is overridden 2016-05-10 14:49:13 -04:00
panic.go panic: Instruct the user to include terraform's version for bug reports. 2015-05-14 18:14:56 -04:00
version.go Expose Terraform version internally & externally 2015-06-21 12:24:42 +01:00

README.md

Terraform

Terraform

Terraform is a tool for building, changing, and versioning infrastructure safely and efficiently. Terraform can manage existing and popular service providers as well as custom in-house solutions.

The key features of Terraform are:

  • Infrastructure as Code: Infrastructure is described using a high-level configuration syntax. This allows a blueprint of your datacenter to be versioned and treated as you would any other code. Additionally, infrastructure can be shared and re-used.

  • Execution Plans: Terraform has a "planning" step where it generates an execution plan. The execution plan shows what Terraform will do when you call apply. This lets you avoid any surprises when Terraform manipulates infrastructure.

  • Resource Graph: Terraform builds a graph of all your resources, and parallelizes the creation and modification of any non-dependent resources. Because of this, Terraform builds infrastructure as efficiently as possible, and operators get insight into dependencies in their infrastructure.

  • Change Automation: Complex changesets can be applied to your infrastructure with minimal human interaction. With the previously mentioned execution plan and resource graph, you know exactly what Terraform will change and in what order, avoiding many possible human errors.

For more information, see the introduction section of the Terraform website.

Getting Started & Documentation

All documentation is available on the Terraform website.

Developing Terraform

If you wish to work on Terraform itself or any of its built-in providers, you'll first need Go installed on your machine (version 1.6+ is required). Alternatively, you can use the Vagrantfile in the root of this repo to stand up a virtual machine with the appropriate dev tooling already set up for you.

For local dev first make sure Go is properly installed, including setting up a GOPATH. You will also need to add $GOPATH/bin to your $PATH.

Next, using Git, clone this repository into $GOPATH/src/github.com/hashicorp/terraform. All the necessary dependencies are either vendored or automatically installed, so you just need to type make. This will compile the code and then run the tests. If this exits with exit status 0, then everything is working!

$ make

To compile a development version of Terraform and the built-in plugins, run make dev. This will build everything using gox and put Terraform binaries in the bin and $GOPATH/bin folders:

$ make dev
...
$ bin/terraform
...

If you're developing a specific package, you can run tests for just that package by specifying the TEST variable. For example below, onlyterraform package tests will be run.

$ make test TEST=./terraform
...

If you're working on a specific provider and only wish to rebuild that provider, you can use the plugin-dev target. For example, to build only the Azure provider:

$ make plugin-dev PLUGIN=provider-azure

If you're working on the core of Terraform, and only wish to rebuild that without rebuilding providers, you can use the core-dev target. It is important to note that some types of changes may require both core and providers to be rebuilt - for example work on the RPC interface. To build just the core of Terraform:

$ make core-dev

Dependencies

Terraform stores its dependencies under vendor/, which Go 1.6+ will automatically recognize and load. We use govendor to manage the vendored dependencies.

If you're developing Terraform, there are a few tasks you might need to perform.

Adding a dependency

If you're adding a dependency, you'll need to vendor it in the same Pull Request as the code that depends on it. You should do this in a separate commit from your code, as makes PR review easier and Git history simpler to read in the future.

To add a dependency:

Assuming your work is on a branch called my-feature-branch, the steps look like this:

  1. Add the new package to your GOPATH:

    go get github.com/hashicorp/my-project
    
  2. Add the new package to your vendor/ directory:

    govendor add github.com/hashicorp/my-project/package
    
  3. Review the changes in git and commit them.

Updating a dependency

To update a dependency:

  1. Fetch the dependency:

    govendor fetch github.com/hashicorp/my-project
    
  2. Review the changes in git and commit them.

Acceptance Tests

Terraform has a comprehensive acceptance test suite covering the built-in providers. Our Contributing Guide includes details about how and when to write and run acceptance tests in order to help contributions get accepted quickly.

Cross Compilation and Building for Distribution

If you wish to cross-compile Terraform for another architecture, you can set the XC_OS and XC_ARCH environment variables to values representing the target operating system and architecture before calling make. The output is placed in the pkg subdirectory tree both expanded in a directory representing the OS/architecture combination and as a ZIP archive.

For example, to compile 64-bit Linux binaries on Mac OS X Linux, you can run:

$ XC_OS=linux XC_ARCH=amd64 make bin 
...
$ file pkg/linux_amd64/terraform
terraform: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped

XC_OS and XC_ARCH can be space separated lists representing different combinations of operating system and architecture. For example, to compile for both Linux and Mac OS X, targeting both 32- and 64-bit architectures, you can run:

$ XC_OS="linux darwin" XC_ARCH="386 amd64" make bin
...
$ tree ./pkg/ -P "terraform|*.zip"
./pkg/
├── darwin_386
│   └── terraform
├── darwin_386.zip
├── darwin_amd64
│   └── terraform
├── darwin_amd64.zip
├── linux_386
│   └── terraform
├── linux_386.zip
├── linux_amd64
│   └── terraform
└── linux_amd64.zip

4 directories, 8 files

Note: Cross-compilation uses gox, which requires toolchains to be built with versions of Go prior to 1.5. In order to successfully cross-compile with older versions of Go, you will need to run gox -build-toolchain before running the commands detailed above.