terraform/internal/addrs
Martin Atkins affe2c3295 addrs: Expose the registry address parser's error messages
Previously we ended up losing all of the error message detail produced by
the registry address parser, because we treated any registry address
failure as cause to parse the address as a go-getter-style remote address
instead.

That led to terrible feedback in the situation where the user _was_
trying to write a module address but it was invalid in some way.

Although we can't really tighten this up in the default case due to our
compatibility promises, it's never been valid to use the "version"
argument with anything other than a registry address and so as a
compromise here we'll use the presence of "version" as a heuristic for
user intent to parse the source address as a registry address, and thus
we can return a registry-address-specific error message in that case and
thus give more direct feedback about what was wrong.

This unfortunately won't help someone trying to install from the registry
_without_ a version constraint, but I didn't want to let perfect be the
enemy of the good here, particularly since we recommend using version
constraints with registry modules anyway; indeed, that's one of the main
benefits of using a registry rather than a remote source directly.
2021-11-30 15:46:16 -08:00
..
count_attr.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
doc.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
for_each_attr.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
input_variable.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
instance_key.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
local_value.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
module.go addrs: AbsMoveable, ConfigMoveable, and MoveableEndpoint 2021-07-01 08:28:02 -07:00
module_call.go Equal methods for move AbsMoveable 2021-08-10 10:12:17 -04:00
module_instance.go addrs: ModuleInstance.ChildCall method 2021-07-28 13:54:10 -07:00
module_instance_test.go states: new `Move` funcs for Resource, ResourceInstance, and ModuleInstances (#29068) 2021-07-13 16:10:46 -04:00
module_package.go addrs: ModuleRegistryPackage for representing module registry packages 2021-06-03 08:50:34 -07:00
module_source.go addrs: Expose the registry address parser's error messages 2021-11-30 15:46:16 -08:00
module_source_test.go addrs: Expose the registry address parser's error messages 2021-11-30 15:46:16 -08:00
module_test.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
move_endpoint.go remove occurrences of AbsMovable 2021-11-15 11:05:33 +00:00
move_endpoint_kind.go addrs: MoveEndpointInModule 2021-07-14 17:37:48 -07:00
move_endpoint_module.go remove occurrences of AbsMovable 2021-11-15 11:05:33 +00:00
move_endpoint_module_test.go addrs: MoveEndpointInModule.SelectsResource 2021-09-20 09:06:22 -07:00
move_endpoint_test.go remove occurrences of AbsMovable 2021-11-15 11:05:33 +00:00
moveable.go add AffectedAbsResource to interface 2021-11-16 18:19:11 +00:00
moveendpointkind_string.go addrs: MoveEndpointInModule 2021-07-14 17:37:48 -07:00
output_value.go addrs: Rename AbsModuleCallOutput to ModuleCallInstanceOutput 2021-07-01 08:28:02 -07:00
output_value_test.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
parse_ref.go addrs: Rename AbsModuleCallOutput to ModuleCallInstanceOutput 2021-07-01 08:28:02 -07:00
parse_ref_test.go addrs: Rename AbsModuleCallOutput to ModuleCallInstanceOutput 2021-07-01 08:28:02 -07:00
parse_target.go addrs: AbsMoveable, ConfigMoveable, and MoveableEndpoint 2021-07-01 08:28:02 -07:00
parse_target_test.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
path_attr.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
provider.go addrs: Rename DefaultRegistryHost to DefaultProviderRegistryHost 2021-06-03 08:50:34 -07:00
provider_config.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
provider_config_test.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
provider_test.go addrs: Rename DefaultRegistryHost to DefaultProviderRegistryHost 2021-06-03 08:50:34 -07:00
referenceable.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
resource.go add AffectedAbsResource to interface 2021-11-16 18:19:11 +00:00
resource_phase.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
resource_test.go addrs: AbsResource.UniqueKey distinct from AbsResourceInstance.UniqueKey 2021-09-22 09:01:10 -07:00
resourcemode_string.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
self.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
set.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
target_test.go Move addrs/ to internal/addrs/ 2021-05-17 14:09:07 -07:00
targetable.go configs: add decodeMovedBlock behind a locked gate. (#28973) 2021-06-21 10:53:16 -04:00
terraform_attr.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
unique_key.go addrs: UniqueKey and UniqueKeyer 2021-07-14 17:37:48 -07:00
unique_key_test.go addrs: ModuleInstance and AbsResourceInstance are UniqueKeyers 2021-07-14 17:37:48 -07:00