test planfile may need to have a specific lineage

In order to test applying a plan from an existing state, we need to be
able to inject the state meta into the planfile.
This commit is contained in:
James Bardin 2021-10-13 17:28:14 -04:00
parent 5ffa0839f9
commit 9c80574417
2 changed files with 24 additions and 5 deletions

View File

@ -710,7 +710,6 @@ func TestApply_plan(t *testing.T) {
} }
func TestApply_plan_backup(t *testing.T) { func TestApply_plan_backup(t *testing.T) {
planPath := applyFixturePlanFile(t)
statePath := testTempFile(t) statePath := testTempFile(t)
backupPath := testTempFile(t) backupPath := testTempFile(t)
@ -724,11 +723,17 @@ func TestApply_plan_backup(t *testing.T) {
} }
// create a state file that needs to be backed up // create a state file that needs to be backed up
err := statemgr.NewFilesystem(statePath).WriteState(states.NewState()) fs := statemgr.NewFilesystem(statePath)
fs.StateSnapshotMeta()
err := fs.WriteState(states.NewState())
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
} }
// the plan file must contain the metadata from the prior state to be
// backed up
planPath := applyFixturePlanFileMatchState(t, fs.StateSnapshotMeta())
args := []string{ args := []string{
"-state", statePath, "-state", statePath,
"-backup", backupPath, "-backup", backupPath,
@ -2280,6 +2285,13 @@ func applyFixtureProvider() *terraform.MockProvider {
// a single change to create the test_instance.foo that is included in the // a single change to create the test_instance.foo that is included in the
// "apply" test fixture, returning the location of that plan file. // "apply" test fixture, returning the location of that plan file.
func applyFixturePlanFile(t *testing.T) string { func applyFixturePlanFile(t *testing.T) string {
return applyFixturePlanFileMatchState(t, statemgr.SnapshotMeta{})
}
// applyFixturePlanFileMatchState creates a planfile like applyFixturePlanFile,
// but inserts the state meta information if that plan must match a preexisting
// state.
func applyFixturePlanFileMatchState(t *testing.T, stateMeta statemgr.SnapshotMeta) string {
_, snap := testModuleWithSnapshot(t, "apply") _, snap := testModuleWithSnapshot(t, "apply")
plannedVal := cty.ObjectVal(map[string]cty.Value{ plannedVal := cty.ObjectVal(map[string]cty.Value{
"id": cty.UnknownVal(cty.String), "id": cty.UnknownVal(cty.String),
@ -2310,11 +2322,12 @@ func applyFixturePlanFile(t *testing.T) string {
After: plannedValRaw, After: plannedValRaw,
}, },
}) })
return testPlanFile( return testPlanFileMatchState(
t, t,
snap, snap,
states.NewState(), states.NewState(),
plan, plan,
stateMeta,
) )
} }

View File

@ -229,15 +229,21 @@ func testPlan(t *testing.T) *plans.Plan {
} }
func testPlanFile(t *testing.T, configSnap *configload.Snapshot, state *states.State, plan *plans.Plan) string { func testPlanFile(t *testing.T, configSnap *configload.Snapshot, state *states.State, plan *plans.Plan) string {
return testPlanFileMatchState(t, configSnap, state, plan, statemgr.SnapshotMeta{})
}
func testPlanFileMatchState(t *testing.T, configSnap *configload.Snapshot, state *states.State, plan *plans.Plan, stateMeta statemgr.SnapshotMeta) string {
t.Helper() t.Helper()
stateFile := &statefile.File{ stateFile := &statefile.File{
Lineage: "", Lineage: stateMeta.Lineage,
Serial: stateMeta.Serial,
State: state, State: state,
TerraformVersion: version.SemVer, TerraformVersion: version.SemVer,
} }
prevStateFile := &statefile.File{ prevStateFile := &statefile.File{
Lineage: "", Lineage: stateMeta.Lineage,
Serial: stateMeta.Serial,
State: state, // we just assume no changes detected during refresh State: state, // we just assume no changes detected during refresh
TerraformVersion: version.SemVer, TerraformVersion: version.SemVer,
} }