219aa3e788
helper/schema: fix DiffFieldReader map handling
...
An `InstanceDiff` will include `ResourceAttrDiff` entries for the
"length" / `#` field of maps. This makes sense, since for something like
`terraform plan` it's useful to see when counts are changing.
The `DiffFieldReader` was not taking these entries into account when
reading maps out, and was therefore incorrectly returning maps that
included an extra `'#'` field, which was causing all sorts of havoc
for providers (extra tags on AWS instances, broken google compute
instance launch, possibly others).
* fixes #914 - extra tags on AWS instances
* fixes #883 - general core issue sprouted from #757
* removes the hack+TODO from #757
2015-02-03 20:17:57 -06:00
3cb5ba01a7
whitespace: fix mixed case indent
2015-01-28 05:16:04 -06:00
c88c4a33e1
providers/aws: ignore ec2 root devices
...
fixes #859
EC2 root block devices are attached automatically at launch [1] and show
up in DescribeInstances responses from then on. By skipping these when
recording state, Terraform can avoid thinking there should be block
device changes when there are none.
Note this requires that https://github.com/mitchellh/goamz/pull/214 land
first so the proper field is exposed.
[1] http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/RootDeviceStorage.html
2015-01-28 05:14:21 -06:00
13f1f1f9ad
builtin/providers/aws: acceptance tests for assigning private IPs on AWS instance
2014-12-20 20:48:07 +01:00
86aafdb839
test for tenancy schema
2014-12-03 15:58:51 +05:30
f63e032c23
Merge remote-tracking branch 'upstream/master'
2014-11-26 17:06:42 +05:30
d3e1a6678d
Making some last tweaks and fixing some acc tests
2014-11-24 21:22:18 +01:00
eccd5ad308
Refactored about 90%
...
Still need to update 2 resources and check the acceptance tests, but
overall we’re nearly there 😃
2014-11-21 17:58:34 +01:00
750a36c51e
AWS instance resource now supports tenancy
2014-11-04 16:38:30 +05:30
9fa25c40b2
tests for aws instance block_device
2014-10-31 16:25:16 -04:00
895d978065
fmt
2014-10-18 10:59:23 -07:00
e59e4a6bd9
providers/aws: fix compile error
2014-10-14 12:20:39 -07:00
ce997a9a33
providers/aws: fix test
2014-10-14 12:15:46 -07:00
3e16190e69
Expands AWS tagging to cover EC2 instances
2014-10-13 16:55:59 -04:00
c5d6df692d
providers/aws: tests passing, compiles
2014-09-16 17:49:24 -07:00
c6741cf1b5
providers/aws: add tests for instance availability zone
...
cc/ @dcosson here we go!
2014-07-31 20:35:31 -04:00
974074fee9
Add associate_public_ip_address as an attribute of the aws_instance resource
2014-07-29 22:06:53 +10:00
0d8f6645fa
providers/aws/aws_instance: user_data diffs properly
2014-07-16 16:41:20 -07:00
082790c4c1
providers/aws: basic user data, doesn't fully work yet because diffs are broke
2014-07-16 09:01:56 -07:00
16c99e78b3
providers/aws: security_groups support
2014-07-14 21:56:37 -07:00
735c909264
providers/aws/aws_instance: test modifying source_dest_check
2014-07-14 17:38:56 -07:00
2fa6ca1c4e
providers/aws/aws_instance: source_dest_check support
2014-07-14 14:16:59 -07:00
88dd1baafe
providers/aws/aws_instance: can bring up in VPC
2014-07-14 13:46:32 -07:00
9f96fb4aac
providers/aws: basic aws_instance test
2014-07-14 13:28:00 -07:00
Paul Hinze